public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-9925] aarch64: Fix _BitInt testcases
@ 2024-04-11 16:54 Richard Sandiford
  0 siblings, 0 replies; only message in thread
From: Richard Sandiford @ 2024-04-11 16:54 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:b87ba79200f2a727aa5c523abcc5c03fa11fc007

commit r14-9925-gb87ba79200f2a727aa5c523abcc5c03fa11fc007
Author: Andre Vieira (lists) <andre.simoesdiasvieira@arm.com>
Date:   Thu Apr 11 17:54:37 2024 +0100

    aarch64: Fix _BitInt testcases
    
    This patch fixes some testisms introduced by:
    
    commit 5aa3fec38cc6f52285168b161bab1a869d864b44
    Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
    Date:   Wed Apr 10 16:29:46 2024 +0100
    
         aarch64: Add support for _BitInt
    
    The testcases were relying on an unnecessary sign-extend that is no longer
    generated.
    
    The tested version was just slightly behind top of trunk when the patch
    was committed, and the codegen had changed, for the better, by then.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/aarch64/bitfield-bitint-abi-align16.c (g1, g8, g16, g1p, g8p,
            g16p): Remove unnecessary sbfx.
            * gcc.target/aarch64/bitfield-bitint-abi-align8.c (g1, g8, g16, g1p, g8p,
            g16p): Likewise.

Diff:
---
 .../aarch64/bitfield-bitint-abi-align16.c          | 30 +++++++++-------------
 .../aarch64/bitfield-bitint-abi-align8.c           | 30 +++++++++-------------
 2 files changed, 24 insertions(+), 36 deletions(-)

diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align16.c b/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align16.c
index 3f292a45f95..4a228b0a1ce 100644
--- a/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align16.c
+++ b/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align16.c
@@ -55,9 +55,8 @@
 ** g1:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f1
 */
@@ -66,9 +65,8 @@
 ** g8:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f8
 */
@@ -76,9 +74,8 @@
 ** g16:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f16
 */
@@ -107,9 +104,8 @@
 /*
 ** g1p:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f1p
@@ -117,9 +113,8 @@
 /*
 ** g8p:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f8p
@@ -128,9 +123,8 @@
 ** g16p:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f16p
 */
diff --git a/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align8.c b/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align8.c
index da3c23550ba..e7f773640f0 100644
--- a/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align8.c
+++ b/gcc/testsuite/gcc.target/aarch64/bitfield-bitint-abi-align8.c
@@ -54,9 +54,8 @@
 /*
 ** g1:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f1
@@ -65,9 +64,8 @@
 /*
 ** g8:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f8
@@ -76,9 +74,8 @@
 ** g16:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f16
 */
@@ -107,9 +104,8 @@
 /*
 ** g1p:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f1p
@@ -117,9 +113,8 @@
 /*
 ** g8p:
 **	mov	(w[0-9]+), w1
-**	sbfx	(x[0-9]+), x0, 0, 63
-**	and	x3, \2, 9223372036854775807
-**	and	x1, \2, 1
+**	and	x3, x0, 9223372036854775807
+**	and	x1, x0, 1
 **	mov	x2, 0
 **	mov	w0, \1
 **	b	f8p
@@ -128,9 +123,8 @@
 ** g16p:
 **	mov	(x[0-9]+), x0
 **	mov	w0, w1
-**	sbfx	(x[0-9]+), \1, 0, 63
-**	and	x4, \2, 9223372036854775807
-**	and	x2, \2, 1
+**	and	x4, \1, 9223372036854775807
+**	and	x2, \1, 1
 **	mov	x3, 0
 **	b	f16p
 */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-11 16:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-11 16:54 [gcc r14-9925] aarch64: Fix _BitInt testcases Richard Sandiford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).