public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-9971] gcov-profile/114715 - missing coverage for switch
@ 2024-04-15 11:43 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2024-04-15 11:43 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:9d573f71e80e9f6f4aac912fc8fc128aa2697e3a
commit r14-9971-g9d573f71e80e9f6f4aac912fc8fc128aa2697e3a
Author: Richard Biener <rguenther@suse.de>
Date: Mon Apr 15 11:09:17 2024 +0200
gcov-profile/114715 - missing coverage for switch
The following avoids missing coverage for the line of a switch statement
which happens when gimplification emits a BIND_EXPR wrapping the switch
as that prevents us from setting locations on the containing statements
via annotate_all_with_location. Instead set the location of the GIMPLE
switch directly.
PR gcov-profile/114715
* gimplify.cc (gimplify_switch_expr): Set the location of the
GIMPLE switch.
* gcc.misc-tests/gcov-24.c: New testcase.
Diff:
---
gcc/gimplify.cc | 1 +
gcc/testsuite/gcc.misc-tests/gcov-24.c | 30 ++++++++++++++++++++++++++++++
2 files changed, 31 insertions(+)
diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc
index 3b731525f15..457b33a4293 100644
--- a/gcc/gimplify.cc
+++ b/gcc/gimplify.cc
@@ -3013,6 +3013,7 @@ gimplify_switch_expr (tree *expr_p, gimple_seq *pre_p)
switch_stmt = gimple_build_switch (SWITCH_COND (switch_expr),
default_case, labels);
+ gimple_set_location (switch_stmt, EXPR_LOCATION (switch_expr));
/* For the benefit of -Wimplicit-fallthrough, if switch_body_seq
ends with a GIMPLE_LABEL holding SWITCH_BREAK_LABEL_P LABEL_DECL,
wrap the GIMPLE_SWITCH up to that GIMPLE_LABEL into a GIMPLE_BIND,
diff --git a/gcc/testsuite/gcc.misc-tests/gcov-24.c b/gcc/testsuite/gcc.misc-tests/gcov-24.c
new file mode 100644
index 00000000000..395099bd7ae
--- /dev/null
+++ b/gcc/testsuite/gcc.misc-tests/gcov-24.c
@@ -0,0 +1,30 @@
+/* { dg-options "-fprofile-arcs -ftest-coverage" } */
+/* { dg-do run { target native } } */
+
+int main()
+{
+ int a = 1;
+ int b = 2;
+ int c = -3;
+ switch(a) /* count(1) */
+ {
+ case 1: /* count(1) */
+ c = 3;
+ switch(b) { /* count(1) */
+ case 1: /* count(#####) */
+ c = 4;
+ break;
+ case 2: /* count(1) */
+ c = 5;
+ break;
+ }
+ break;
+ case 2: /* count(#####) */
+ c = 6;
+ break;
+ default: /* count(#####) */
+ break;
+ }
+}
+
+/* { dg-final { run-gcov gcov-24.c } } */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-15 11:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-15 11:43 [gcc r14-9971] gcov-profile/114715 - missing coverage for switch Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).