public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-11383] Objective-C, Darwin: Fix a regression in handling bad receivers.
@ 2024-04-27 16:24 Iain D Sandoe
0 siblings, 0 replies; only message in thread
From: Iain D Sandoe @ 2024-04-27 16:24 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:c01efafd7fc6d3ff58db930fd785a8bcd991ac54
commit r11-11383-gc01efafd7fc6d3ff58db930fd785a8bcd991ac54
Author: Iain Sandoe <iain@sandoe.co.uk>
Date: Sat Jan 6 19:21:40 2024 +0000
Objective-C, Darwin: Fix a regression in handling bad receivers.
This is seen on 32b hosts with a 64b multilib, and is an ICE when
the build has checking enabled. The fix is to exit the routine
early if the sender or receiver are already error_mark_node.
gcc/objc/ChangeLog:
* objc-next-runtime-abi-02.c
(build_v2_objc_method_fixup_call): Early exit for cases
where the sender or receiver are known to be in error.
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
(cherry picked from commit 846794ead2982fc85a3b1a83bbb831fa096b2b7c)
Diff:
---
gcc/objc/objc-next-runtime-abi-02.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gcc/objc/objc-next-runtime-abi-02.c b/gcc/objc/objc-next-runtime-abi-02.c
index 2a4f87cc726..0c59299db05 100644
--- a/gcc/objc/objc-next-runtime-abi-02.c
+++ b/gcc/objc/objc-next-runtime-abi-02.c
@@ -1663,6 +1663,8 @@ build_v2_objc_method_fixup_call (int super_flag, tree method_prototype,
rcv_p = (super_flag ? objc_super_type : objc_object_type);
lookup_object = build_c_cast (input_location, rcv_p, lookup_object);
+ if (sender == error_mark_node || lookup_object == error_mark_node)
+ return error_mark_node;
/* Use SAVE_EXPR to avoid evaluating the receiver twice. */
lookup_object = save_expr (lookup_object);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-27 16:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-27 16:24 [gcc r11-11383] Objective-C, Darwin: Fix a regression in handling bad receivers Iain D Sandoe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).