public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return
Date: Sun, 28 Apr 2024 05:21:53 +0000 (GMT)	[thread overview]
Message-ID: <20240428052153.68E0E3858CD1@sourceware.org> (raw)

https://gcc.gnu.org/g:4c42beadc660572409d3e6f452bf4c0209f320c3

commit 4c42beadc660572409d3e6f452bf4c0209f320c3
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Apr 23 00:33:04 2024 -0300

    make -freg-struct-return visibly a negative alias of -fpcc-struct-return
    
    The fact that both options accept negative forms suggests that maybe
    they aren't negative forms of each other.  They are, but that isn't
    clear even by examining common.opt.  Use NegativeAlias to make it
    abundantly clear.
    
    The 'Optimization' keyword next to freg-struct-return was the only
    thing that caused flag_pcc_struct_return to be a per-function flag,
    and ipa-inline relied on that.  After making it an alias, the
    Optimization keyword was no longer operational.  I'm not sure it was
    sensible or desirable for flag_pcc_struct_return to be a per-function
    setting, but this patch does not intend to change behavior.
    
    
    for  gcc/ChangeLog
    
            * common.opt (freg-struct-return): Make it explicitly
            fpcc-struct-return's NegativeAlias.  Copy Optimization...
            (freg-struct-return): ... here.

Diff:
---
 gcc/common.opt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/common.opt b/gcc/common.opt
index ad348844775..12d93c76a1e 100644
--- a/gcc/common.opt
+++ b/gcc/common.opt
@@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization
 -fpack-struct=<number>	Set initial maximum structure member alignment.
 
 fpcc-struct-return
-Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN)
+Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Optimization
 Return small aggregates in memory, not registers.
 
 fpeel-loops
@@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches)
 Record gcc command line switches in the object file.
 
 freg-struct-return
-Common Var(flag_pcc_struct_return,0) Optimization
+Common NegativeAlias Alias(fpcc_struct_return) Optimization
 Return small aggregates in registers.
 
 fregmove

             reply	other threads:[~2024-04-28  5:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-28  5:21 Alexandre Oliva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-23  4:20 Alexandre Oliva
2024-04-23  3:59 Alexandre Oliva
2024-04-23  3:50 Alexandre Oliva
2024-04-23  3:48 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240428052153.68E0E3858CD1@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).