simple c question

simple c question

[max]

hi!

i'm new to this list and i hope i'm not bothering you with this simple 
stuff:

i'm having problems with strings.

i want to get a path without filename into a string.

and the code is this:

/////////////////////////////////////////////////

// string.h included of course...

char * GetPath (char * string)
{
	char * path;
	int i, pos=-1;
	
	for(i=0;string[i]!=0;i++)
	{
		if(string[i]=='/')
			pos=i;
	}

	if(pos==-1)
		return NULL;
	
	strncpy(path, string, pos+1);
	
return path;
}

////////////////////////////////////////////

i don't get it to work.

can someone please help me?

thank you!

-- 
-----------------------------------------------
----------------maximilian marcoll-------------
-----------composition | performance-----------
http://icem-www.folkwang-hochschule.de/~marcoll
-----------------------------------------------

Re: simple c question

[max]

thank you all for your help!


max

Re: simple c question

[Reuti]

Hi there,

>/////////////////////////////////////////////////
>
>// string.h included of course...
>
>char * GetPath (char * string)
>{
>	char * path;
>	int i, pos=-1;
>	
>	for(i=0;string[i]!=0;i++)
>	{
>		if(string[i]=='/')
>			pos=i;
>	}
>
>	if(pos==-1)
>		return NULL;
>	
>	strncpy(path, string, pos+1);
>	
>return path;
>}
>
>////////////////////////////////////////////

you are not allocating any memory for *path (it's just a pointer), where the 
strncpy could copy anythinkg to.

void GetPath (char* string, char* result)
{
    char *path;

    strcpy(result, string);
    path=strrchr(result, '/');
    if (path==NULL)
        result[0]=0;
    else
        *(path+1)=0;
}

Greetings - Reuti

PS: Once upon the time a lived at the Umstraße...