From: Centurion <centurionn009@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-help@gcc.gnu.org
Subject: Re: your mail
Date: Sun, 24 Mar 2024 13:30:16 +0400 [thread overview]
Message-ID: <CAKDwa5XC3mhp1dJtBtz4o1XrPsu=y5V4+cozxFCahQa8RMzztg@mail.gmail.com> (raw)
In-Reply-To: <20240321152611.GC19790@gate.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 2770 bytes --]
```
bool
find_template_parameter_info::found (tree parm)
{
if (TREE_CODE (parm) == TREE_LIST)
parm = TREE_VALUE (parm);
if (TREE_CODE (parm) == TYPE_DECL)
parm = TREE_TYPE (parm);
else
parm = DECL_INITIAL (parm);
gcc_checking_assert (TEMPLATE_PARM_P (parm));
return parms.contains (parm);
}
```
Is there a reason why TREE_TYPE used only for TYPE_DECL, but not for
TEMPLATE_DECL ? process_template_parm initializes DECL_INITIAL for non type
template parameters, but TYPE_DECL and TEMPLATE_DECL, stayed with nullptr,
on the other hand as I understood it always initializes TREE_TYPE.
cp/pt.cc::tree process_template_parm:
```
if (parm && TREE_CODE (parm) == TEMPLATE_DECL)
{
t = cxx_make_type (TEMPLATE_TEMPLATE_PARM);
...
TREE_TYPE (result) = t;
...
}
else
{
t = cxx_make_type (TEMPLATE_TYPE_PARM);
/* parm is either IDENTIFIER_NODE or NULL_TREE. */
decl = build_decl (parm_loc,
TYPE_DECL, parm, t);
}
```
In other similar pieces of code the condition is for both for TYPE_DECL and
TEMLATE_DECL:
cp/pt.cc::tree template_parm_to_arg:
```
if (DECL_P (t) && DECL_TEMPLATE_PARM_P (t))
{
if (TREE_CODE (t) == TYPE_DECL
|| TREE_CODE (t) == TEMPLATE_DECL)
t = TREE_TYPE (t);
else
t = DECL_INITIAL (t);
}
```
cp/pt.cc::tree get_template_parm_index:
```
if (TREE_CODE (parm) == PARM_DECL
|| TREE_CODE (parm) == CONST_DECL)
parm = DECL_INITIAL (parm);
else if (TREE_CODE (parm) == TYPE_DECL
|| TREE_CODE (parm) == TEMPLATE_DECL)
parm = TREE_TYPE (parm);
```
Sorry if I ask stupid question.
On Thu, Mar 21, 2024 at 7:28 PM Segher Boessenkool <
segher@kernel.crashing.org> wrote:
> On Thu, Mar 21, 2024 at 07:12:23PM +0400, Centurion via Gcc-help wrote:
> > HI, I am new in gcc codebase. Can you explain please why we can't just
> use
> > TREE_TYPE(parm) for TEMLATE_TEMPLATE_PARM and why DECL_INITIAL is needed
> > for it? I tried to debug Bug 114377 and it seems to work fine. Thanks
>
> You cannot use TREE_TYPE if that would just access nonsense data.
>
> The wrong thing might still work, in many cases. If you have no
> substantiation why your proposed change would work fine, chances are it
> does not. Sorry.
>
>
> Segher
>
>
> > --- a/gcc/cp/pt.cc
> > +++ b/gcc/cp/pt.cc
> > @@ -11032,10 +11032,7 @@ find_template_parameter_info::found (tree parm)
> > {
> > if (TREE_CODE (parm) == TREE_LIST)
> > parm = TREE_VALUE (parm);
> > - if (TREE_CODE (parm) == TYPE_DECL)
> > - parm = TREE_TYPE (parm);
> > - else
> > - parm = DECL_INITIAL (parm);
> > + parm = TREE_TYPE(parm);
> > gcc_checking_assert (TEMPLATE_PARM_P (parm));
> > return parms.contains (parm);
> > }
>
next prev parent reply other threads:[~2024-03-24 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 15:12 Centurion
2024-03-21 15:26 ` your mail Segher Boessenkool
2024-03-24 9:30 ` Centurion [this message]
[not found] <20040223154755.23916.qmail@web41606.mail.yahoo.com>
2004-02-23 16:42 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKDwa5XC3mhp1dJtBtz4o1XrPsu=y5V4+cozxFCahQa8RMzztg@mail.gmail.com' \
--to=centurionn009@gmail.com \
--cc=gcc-help@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).