From: Qing Zhao <qing.zhao@oracle.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
"Sandra@codesourcery.com" <Sandra@codesourcery.com>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
Richard Biener <richard.guenther@gmail.com>,
Kees Cook <keescook@chromium.org>,
gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]
Date: Mon, 27 Mar 2023 13:31:59 +0000 [thread overview]
Message-ID: <000C1AC3-F7D7-4042-9573-65AAE2456197@oracle.com> (raw)
In-Reply-To: <7798934b-7182-eda8-604d-3a56f517b98a@codesourcery.com>
> On Mar 23, 2023, at 2:55 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>
> On Thu, 23 Mar 2023, Qing Zhao via Gcc-patches wrote:
>
>> gcc/c/ChangeLog:
>>
>> PR tree-optimization/101832
>> * c-decl.cc<http://c-decl.cc> (finish_struct): Set TYPE_INCLUDE_FLEXARRAY for
>> struct/union type.
>
> The C front-end changes are OK (supposing the original patch has correct
> whitespace, since it seems to be messed up here).
Thanks for your review.
I just double checked the change in gcc/c/c-decl.cc, looks like the whitespaces are good:
diff --git a/gcc/c/c-decl.cc b/gcc/c/c-decl.cc
index e537d33f398..14c54809b9d 100644
--- a/gcc/c/c-decl.cc
+++ b/gcc/c/c-decl.cc
@@ -9258,6 +9258,17 @@ finish_struct (location_t loc, tree t, tree fieldlist, tree attributes,
/* Set DECL_NOT_FLEXARRAY flag for FIELD_DECL x. */
DECL_NOT_FLEXARRAY (x) = !is_flexible_array_member_p (is_last_field, x);
+ /* Set TYPE_INCLUDE_FLEXARRAY for the context of x, t.
+ when x is an array and is the last field. */
+ if (TREE_CODE (TREE_TYPE (x)) == ARRAY_TYPE)
+ TYPE_INCLUDE_FLEXARRAY (t)
+ = is_last_field && flexible_array_member_type_p (TREE_TYPE (x));
+ /* Recursively set TYPE_INCLUDE_FLEXARRAY for the context of x, t
+ when x is an union or record and is the last field. */
+ else if (RECORD_OR_UNION_TYPE_P (TREE_TYPE (x)))
+ TYPE_INCLUDE_FLEXARRAY (t)
+ = is_last_field && TYPE_INCLUDE_FLEXARRAY (TREE_TYPE (x));
+
if (DECL_NAME (x)
|| RECORD_OR_UNION_TYPE_P (TREE_TYPE (x)))
saw_named_field = true;
I guess that the git send-mail might mess up them. -:).
Qing
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
next prev parent reply other threads:[~2023-03-27 13:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 21:47 [V5][PATCH 0/2] Handle component_ref to a structure/union field including FAM for builtin_object_size Qing Zhao
2023-03-16 21:47 ` [V5][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832] Qing Zhao
2023-03-23 13:03 ` Fwd: " Qing Zhao
2023-03-23 18:55 ` Joseph Myers
2023-03-27 13:31 ` Qing Zhao [this message]
2023-03-27 14:22 ` Qing Zhao
2023-03-16 21:47 ` [V5][PATCH 2/2] Update documentation to clarify a GCC extension Qing Zhao
2023-03-23 13:05 ` Fwd: " Qing Zhao
2023-03-23 20:14 ` Joseph Myers
2023-03-27 13:38 ` Qing Zhao
2023-03-27 14:34 ` Xi Ruoyao
2023-03-27 15:37 ` Qing Zhao
2023-03-27 15:43 ` Jakub Jelinek
2023-03-27 15:57 ` Qing Zhao
2023-03-27 16:06 ` Jakub Jelinek
2023-03-27 16:22 ` Qing Zhao
2023-03-27 16:31 ` Jakub Jelinek
2023-03-27 16:48 ` Qing Zhao
2023-03-27 17:29 ` Qing Zhao
2023-03-23 13:02 ` Fwd: [V5][PATCH 0/2] Handle component_ref to a structure/union field including FAM for builtin_object_size Qing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=000C1AC3-F7D7-4042-9573-65AAE2456197@oracle.com \
--to=qing.zhao@oracle.com \
--cc=Sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=keescook@chromium.org \
--cc=richard.guenther@gmail.com \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).