public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: davidxl@google.com
To: xur@google.com, dnovillo@google.com
Cc: gcc-patches@gcc.gnu.org, reply@codereview.appspotmail.com
Subject: Re: [google] limit excessive load/store motions (issue4563044)
Date: Fri, 10 Jun 2011 18:29:00 -0000	[thread overview]
Message-ID: <0023547c8caf16ebf804a55f5ec0@google.com> (raw)

Ok for google/main after the minor cleanups. Incorporate comments from
maintainers when available.

David


http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c
File gcc/gcse.c (right):

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5050
gcc/gcse.c:5050: if (ld_motion_count >= ld_motion_limit)
Can you merge the check with the check below?

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5087
gcc/gcse.c:5087: }loop_lsm_limit_map;
Missing space.

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5101
gcc/gcse.c:5101: /* hash equal function for loop_lsm_limit_map_htab */
missing . and one space.

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5107
gcc/gcse.c:5107: *const ptr2 = (const loop_lsm_limit_map *) p2;
indentation problem.

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5112
gcc/gcse.c:5112: /* free one entry in loop_lsm_limit_map_htab */
. and space

http://codereview.appspot.com/4563044/diff/1/gcc/gcse.c#newcode5254
gcc/gcse.c:5254: static void
Missing documentation.

http://codereview.appspot.com/4563044/diff/1/gcc/tree-ssa-loop-im.c
File gcc/tree-ssa-loop-im.c (right):

http://codereview.appspot.com/4563044/diff/1/gcc/tree-ssa-loop-im.c#newcode100
gcc/tree-ssa-loop-im.c:100: /* limit for lsm that can be performed for
one loop */
one more space

http://codereview.appspot.com/4563044/

             reply	other threads:[~2011-06-10 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 18:29 davidxl [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-06-10 17:56 Rong Xu
2011-06-10 18:02 ` Diego Novillo
2011-06-10 18:17   ` Rong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0023547c8caf16ebf804a55f5ec0@google.com \
    --to=davidxl@google.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=reply@codereview.appspotmail.com \
    --cc=xur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).