[PATCH] PR bootstrap/106472: Add libgo depends on libbacktrace to Makefile.def

[PATCH] PR bootstrap/106472: Add libgo depends on libbacktrace to Makefile.def

[Roger Sayle]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]


This patch fixes PR bootstrap/106472 by adding a missing dependency
to Makefile.def to allow make bootstrap when configured using
"--enable-languages=go" (and not using make with multiple threads).

Tested on x86-64-pc-linux-gnu.  Ok for mainline?


2022-07-30  Roger Sayle  <roger@nextmovesoftware.com>

ChangeLog
        PR bootstrap/106472
        * Makefile.def (dependencies): Make configure-target-libgo depend
        upon all-target-libbacktrace.


Thanks in advance,
Roger
--


[-- Attachment #2: patchgo.txt --]
[-- Type: text/plain, Size: 642 bytes --]

diff --git a/Makefile.def b/Makefile.def
index 72d5854..8804ba6 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -663,6 +663,7 @@ dependencies = { module=configure-target-newlib; on=all-binutils; };
 dependencies = { module=configure-target-newlib; on=all-ld; };
 dependencies = { module=configure-target-libgfortran; on=all-target-libquadmath; };
 dependencies = { module=configure-target-libgfortran; on=all-target-libbacktrace; };
+dependencies = { module=configure-target-libgo; on=all-target-libbacktrace; };
 
 languages = { language=c;	gcc-check-target=check-gcc; };
 languages = { language=c++;	gcc-check-target=check-c++;

Re: [PATCH] PR bootstrap/106472: Add libgo depends on libbacktrace to Makefile.def

[Ian Lance Taylor]

On Sat, Jul 30, 2022 at 2:38 PM Roger Sayle <roger@nextmovesoftware.com> wrote:
>
>
> This patch fixes PR bootstrap/106472 by adding a missing dependency
> to Makefile.def to allow make bootstrap when configured using
> "--enable-languages=go" (and not using make with multiple threads).
>
> Tested on x86-64-pc-linux-gnu.  Ok for mainline?
>
>
> 2022-07-30  Roger Sayle  <roger@nextmovesoftware.com>
>
> ChangeLog
>         PR bootstrap/106472
>         * Makefile.def (dependencies): Make configure-target-libgo depend
>         upon all-target-libbacktrace.

This is OK.  Thanks.

Ian

[PATCH] Add libgo dependency on libbacktrace.

[Sergei Trofimovich]

From: Sergei Trofimovich <siarheit@google.com>

Noticed missing dependency when regenerated Makefile.in for unrelated
change with 'autoget Makefile.def'.

The change was lost in basepoints/gcc-12-6861-gaeac414923a
("Revert "Fix PR 67102: Add libstdc++ dependancy to libffi" [PR67102]").

/
	Makefile.in: Regenerate.
---
 Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile.in b/Makefile.in
index 13ee95a2602..60077a6aa36 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -66523,6 +66523,7 @@ all-target-liboffloadmic: maybe-all-target-libgomp
 configure-target-newlib: maybe-all-binutils
 configure-target-newlib: maybe-all-ld
 configure-target-libgfortran: maybe-all-target-libbacktrace
+configure-target-libgo: maybe-all-target-libbacktrace
 @endunless gcc-bootstrap
 
 # Dependencies for target modules on other target modules are
-- 
2.37.1

Re: [PATCH] Add libgo dependency on libbacktrace.

[Thomas Schwinge]

Hi!

On 2022-08-18T07:59:50+0100, Sergei Trofimovich via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> Noticed missing dependency when regenerated Makefile.in for unrelated
> change with 'autoget Makefile.def'.

ACK.  (..., and by now pushed in
commit r13-2108-g5dbc94bf13c5ef2f2b777d76d7880fe2153aa37b
"Add libgo dependency on libbacktrace".)

> The change was lost in basepoints/gcc-12-6861-gaeac414923a
> ("Revert "Fix PR 67102: Add libstdc++ dependancy to libffi" [PR67102]").

That'd be my doing, but -- nope.  ;-) (... but no worries, no offense
meant.)

This 'Makefile.in' was simply missing from recent
commit r13-1902-g351e3cad2c5d4dfe43d68ba333bde1d70fa0b807
"PR bootstrap/106472: Add libgo depends on libbacktrace to Makefile.def".


Grüße
 Thomas


> /
>       Makefile.in: Regenerate.
> ---
>  Makefile.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.in b/Makefile.in
> index 13ee95a2602..60077a6aa36 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -66523,6 +66523,7 @@ all-target-liboffloadmic: maybe-all-target-libgomp
>  configure-target-newlib: maybe-all-binutils
>  configure-target-newlib: maybe-all-ld
>  configure-target-libgfortran: maybe-all-target-libbacktrace
> +configure-target-libgo: maybe-all-target-libbacktrace
>  @endunless gcc-bootstrap
>
>  # Dependencies for target modules on other target modules are
> --
> 2.37.1
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

Re: [PATCH] Add libgo dependency on libbacktrace.

[Jeff Law]

On 8/18/22 00:59, Sergei Trofimovich via Gcc-patches wrote:
> From: Sergei Trofimovich <siarheit@google.com>
>
> Noticed missing dependency when regenerated Makefile.in for unrelated
> change with 'autoget Makefile.def'.
>
> The change was lost in basepoints/gcc-12-6861-gaeac414923a
> ("Revert "Fix PR 67102: Add libstdc++ dependancy to libffi" [PR67102]").
>
> /
> 	Makefile.in: Regenerate.

OK.

jeff