From: Tom Honermann <tom@honermann.net>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes.
Date: Mon, 8 Aug 2022 09:45:48 -0400 [thread overview]
Message-ID: <01b6ae2b-51b1-f5e9-53b9-b410b1bb7b26@honermann.net> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2208022210360.861046@digraph.polyomino.org.uk>
On 8/2/22 6:14 PM, Joseph Myers wrote:
> On Tue, 2 Aug 2022, Tom Honermann via Gcc-patches wrote:
>
>> This patch corrects handling of UTF-8 character literals in preprocessing
>> directives so that they are treated as unsigned types in char8_t enabled
>> C++ modes (C++17 with -fchar8_t or C++20 without -fno-char8_t). Previously,
>> UTF-8 character literals were always treated as having the same type as
>> ordinary character literals (signed or unsigned dependent on target or use
>> of the -fsigned-char or -funsigned char options).
> OK in the absence of C++ maintainer objections within 72 hours. (This is
> the case where, when I added support for such literals for C (commit
> 7c5890cc0a0ecea0e88cc39e9fba6385fb579e61), I raised the question of
> whether they should be unsigned in the preprocessor for C++ as well.)
Joseph, would you be so kind as to commit this patch series for me? I
don't have commit access. Thank you in advance!
Tom.
next prev parent reply other threads:[~2022-08-08 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 18:36 [PATCH v4 0/2] Implement C2X N2653 (char8_t) and correct UTF-8 character literal type in preprocessor directives for C++ Tom Honermann
2022-08-02 18:36 ` [PATCH v4 1/2] C: Implement C2X N2653 char8_t and UTF-8 string literal changes Tom Honermann
2022-08-02 22:10 ` Joseph Myers
2022-08-02 18:36 ` [PATCH v4 2/2] preprocessor/106426: Treat u8 character literals as unsigned in char8_t modes Tom Honermann
2022-08-02 22:14 ` Joseph Myers
2022-08-08 13:45 ` Tom Honermann [this message]
2022-08-08 20:01 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b6ae2b-51b1-f5e9-53b9-b410b1bb7b26@honermann.net \
--to=tom@honermann.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).