From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Sandiford <richard.sandiford@arm.com>,
jlaw@ventanamicro.com, vmakarov@redhat.com,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/5] recog: Handle register filters
Date: Sun, 19 Nov 2023 14:51:30 -0700 [thread overview]
Message-ID: <04609c9f-32c9-40aa-afbe-5804d81125e2@gmail.com> (raw)
In-Reply-To: <20231112145229.2924713-3-richard.sandiford@arm.com>
On 11/12/23 07:52, Richard Sandiford wrote:
> The main (but simplest) part of this patch makes constrain_operands
> take register filters into account.
>
> The rest of the patch adds register filter information to
> operand_alternative. Generally, if two register constraints
> have different register filters, it's better if they're in separate
> alternatives. However, the syntax doesn't enforce that, and we can't
> assert it due to inline asms. So it's a choice between (a) adding
> code to enforce consistent filters or (b) dealing with mixes of filters
> in a conservatively correct way (in the sense of not allowing invalid
> operands). The latter seems much easier.
>
> The patch therefore adds a mask of the filters that apply
> to at least one constraint in a given operand alternative.
> A register is OK if it passes all of the filters in the mask.
>
> gcc/
> * recog.h (operand_alternative): Add a register_filters field.
> (alternative_register_filters): New function.
> * recog.cc (preprocess_constraints): Calculate the filters field.
> (constrain_operands): Check register filters.
OK
jeff
next prev parent reply other threads:[~2023-11-19 21:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 14:52 [PATCH 0/5] Add support for operand-specific alignment requirements Richard Sandiford
2023-11-12 14:52 ` [PATCH 1/5] Add register filter operand to define_register_constraint Richard Sandiford
2023-11-19 21:49 ` Jeff Law
2023-11-12 14:52 ` [PATCH 2/5] recog: Handle register filters Richard Sandiford
2023-11-19 21:51 ` Jeff Law [this message]
2023-11-12 14:52 ` [PATCH 3/5] lra: " Richard Sandiford
2023-11-12 14:52 ` [PATCH 4/5] ira: " Richard Sandiford
2023-11-12 14:52 ` [PATCH 5/5] Add an aligned_register_operand predicate Richard Sandiford
2023-11-19 21:52 ` Jeff Law
2023-11-14 0:01 ` [PATCH 0/5] Add support for operand-specific alignment requirements Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04609c9f-32c9-40aa-afbe-5804d81125e2@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
--cc=richard.sandiford@arm.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).