From: Jeff Law <jeffreyalaw@gmail.com>
To: Lewis Hyatt <lhyatt@gmail.com>, gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] libcpp: Update to Unicode 15
Date: Sat, 11 Mar 2023 10:31:15 -0700 [thread overview]
Message-ID: <05375b8f-644f-3f53-4fd9-992267910d64@gmail.com> (raw)
In-Reply-To: <20230309232746.GA8644@ldh-imac.local>
On 3/9/23 16:27, Lewis Hyatt via Gcc-patches wrote:
> On Fri, Nov 04, 2022 at 10:03:13AM +0100, Jakub Jelinek via Gcc-patches wrote:
>> Hi!
>>
>> The following pseudo-patch (for uname2c.h part
>> just a pseudo patch with a lot of changes replaced with ...
>> because it is too large but the important changes like
>> -static const char uname2c_dict[59418] =
>> +static const char uname2c_dict[59891] =
>> -static const unsigned char uname2c_tree[208765] = {
>> +static const unsigned char uname2c_tree[210697] = {
>> are shown, full patch xz compressed will be posted separately
>> due to mail limit) regenerates the libcpp tables with Unicode 15.0.0
>> which added 4489 new characters.
>>
>> As mentioned previously, this isn't just a matter of running the
>> two libcpp/make*.cc programs on the new Unicode files, but one needs
>> to manually update a table inside of makeuname2c.cc according to
>> a table in Unicode text (which is partially reflected in the text
>> files, but e.g. in Unicode 14.0.0 not 100% accurately, in 15.0.0
>> actually accurately).
>> I've also added some randomly chosen subset of those 4489 new
>> characters to a testcase.
>>
>> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> Hi Jakub-
>
> In addition to these files you updated last year for Unicode 15, we also need
> to update generated_cpp_wcwidth.h, which implements cpp_wcwidth() for
> diagnostics so we can output correct column numbers. There is a procedure
> outlined in the file contrib/unicode/README that accomplishes this. Is it OK
> to push the attached patch (gzipped since it is large and uninformative),
> which is the result of following the procedure? It went straightforwardly as
> expected, and bootstrap+regtest on x86-64 Linux is clean. Thanks!
Yes, please go ahead and push it.
jeff
next prev parent reply other threads:[~2023-03-11 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 9:03 Jakub Jelinek
2022-11-04 9:05 ` Jakub Jelinek
2023-03-09 23:27 ` Lewis Hyatt
2023-03-11 17:31 ` Jeff Law [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-11-04 8:55 Jakub Jelinek
2022-11-04 13:38 ` Marek Polacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05375b8f-644f-3f53-4fd9-992267910d64@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=lhyatt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).