From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: install cp-trait.def as part of plugin headers [PR107136]
Date: Tue, 4 Oct 2022 11:43:04 -0400 [thread overview]
Message-ID: <073c025e-cdcb-e332-a55d-6138f8118364@redhat.com> (raw)
In-Reply-To: <20221004004216.1994023-1-ppalka@redhat.com>
On 10/3/22 20:42, Patrick Palka wrote:
> This is apparently needed since we include cp-trait.def from cp-tree.h
> (in order to define the cp_trait_kind enum), as with operators.def.
>
> Tested on x86_64-pc-linux-gnu by doing make install and verifying
> cp-trait.def appears in
>
> $prefix/lib/gcc/x86_64-pc-linux-gnu/13.0.0/plugin/include/cp/
>
> Does this look OK for trunk?
OK.
> PR c++/107136
>
> gcc/cp/ChangeLog:
>
> * Make-lang.in (CP_PLUGIN_HEADERS): Add cp-trait.def.
> ---
> gcc/cp/Make-lang.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/cp/Make-lang.in b/gcc/cp/Make-lang.in
> index 38d8eeed1f0..aa84d6827be 100644
> --- a/gcc/cp/Make-lang.in
> +++ b/gcc/cp/Make-lang.in
> @@ -39,7 +39,7 @@ CXX_INSTALL_NAME := $(shell echo c++|sed '$(program_transform_name)')
> GXX_INSTALL_NAME := $(shell echo g++|sed '$(program_transform_name)')
> CXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo c++|sed '$(program_transform_name)')
> GXX_TARGET_INSTALL_NAME := $(target_noncanonical)-$(shell echo g++|sed '$(program_transform_name)')
> -CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h operators.def
> +CP_PLUGIN_HEADERS := cp-tree.h cxx-pretty-print.h name-lookup.h type-utils.h operators.def cp-trait.def
>
> #\f
> # Define the names for selecting c++ in LANGUAGES.
prev parent reply other threads:[~2022-10-04 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 0:42 Patrick Palka
2022-10-04 15:43 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=073c025e-cdcb-e332-a55d-6138f8118364@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).