From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point
Date: Sat, 11 Jun 2022 17:31:16 +0900 [thread overview]
Message-ID: <0b7a3a36-cbdf-e812-4c04-533b15c9963b@yahoo.co.jp> (raw)
In-Reply-To: <CAMo8BfLjnoMHeG0vtk2A6aYyNck9VuMjk_oP41ZrBe--P+nAnA@mail.gmail.com>
On 2022/06/11 16:58, Max Filippov wrote:
> Hi Suwa-san,
hi!
> this change results in a bunch of ICEs in the tests like this:
> during RTL pass: split2
> gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f':
> gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c:13:1: internal
> compiler error: in gen_split_5, at config/xtensa/xtensa.md:1186
[from config/xtensa/xtensa.md]
if (GET_MODE (x) == SFmode)
REAL_VALUE_TO_TARGET_SINGLE (*CONST_DOUBLE_REAL_VALUE (x), l[0]);
else if (GET_MODE (x) == DFmode)
REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l);
else
gcc_unreachable (); // line 1186
x = gen_rtx_REG (SImode, REGNO (operands[0]));
umm, i don't know how 'XEXP (operands[1], 0)' can be neither SFmode nor
DFmode...
please tell me that test piece of code, and/or apply the below patch and
reply what the compiler print to stderr:
--- gcc/config/xtensa/xtensa.md
+++ gcc/config/xtensa/xtensa.md
@@ -1183,7 +1183,10 @@
else if (GET_MODE (x) == DFmode)
REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l);
else
- gcc_unreachable ();
+ {
+ print_rtl_single (stderr, x);
+ gcc_unreachable ();
+ }
x = gen_rtx_REG (SImode, REGNO (operands[0]));
if (! xtensa_constantsynth (x, l[i]))
emit_move_insn (x, GEN_INT (l[i]));
next prev parent reply other threads:[~2022-06-11 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:26 Takayuki 'January June' Suwa
2022-06-11 7:58 ` Max Filippov
2022-06-11 8:31 ` Takayuki 'January June' Suwa [this message]
2022-06-11 8:49 ` Max Filippov
2022-06-11 9:05 ` Max Filippov
2022-06-11 10:24 ` [PATCH v3 " Takayuki 'January June' Suwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b7a3a36-cbdf-e812-4c04-533b15c9963b@yahoo.co.jp \
--to=jjsuwa_sys3175@yahoo.co.jp \
--cc=gcc-patches@gcc.gnu.org \
--cc=jcmvbkbc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).