From: Andreas Krebbel <krebbel@linux.ibm.com>
To: Robin Dapp <rdapp@linux.ibm.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] s390: Add -munroll-only-small-loops.
Date: Mon, 15 Aug 2022 17:05:47 +0200 [thread overview]
Message-ID: <0bdaaa1b-9387-5309-f89a-5800e3925238@linux.ibm.com> (raw)
In-Reply-To: <4166b06c-7713-2d4a-3c86-54e99f4a9f53@linux.ibm.com>
On 8/12/22 12:00, Robin Dapp wrote:
> Hi,
>
> inspired by Power we also introduce -munroll-only-small-loops. This
> implies activating -funroll-loops and -munroll-only-small-loops at -O2
> and above.
>
> Bootstrapped and regtested.
>
> This introduces one regression in gcc.dg/sms-compare-debug-1.c but
> currently dumps for sms are broken as well. The difference is in the
> location of some INSN_DELETED notes so I would consider this a minor issue.
>
> Is it OK?
>
> Regards
> Robin
>
> gcc/ChangeLog:
>
> * common/config/s390/s390-common.cc: Enable -funroll-loops and
> -munroll-only-small-loops for OPT_LEVELS_2_PLUS_SPEED_ONLY.
> * config/s390/s390.cc (s390_loop_unroll_adjust): Do not unroll
> loops larger than 12 instructions.
> (s390_override_options_after_change): Set unroll options.
> (s390_option_override_internal): Likewise.
> * config/s390/s390.opt: Document munroll-only-small-loops.
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/s390/vector/vec-copysign.c: Do not unroll.
> * gcc.target/s390/zvector/autovec-double-quiet-uneq.c: Dito.
> * gcc.target/s390/zvector/autovec-double-signaling-ltgt.c: Dito.
> * gcc.target/s390/zvector/autovec-float-quiet-uneq.c: Dito.
> * gcc.target/s390/zvector/autovec-float-signaling-ltgt.c: Dito.
Ok. Thanks!
Andreas
prev parent reply other threads:[~2022-08-15 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 10:00 Robin Dapp
2022-08-15 15:05 ` Andreas Krebbel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bdaaa1b-9387-5309-f89a-5800e3925238@linux.ibm.com \
--to=krebbel@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rdapp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).