From: David Malcolm <dmalcolm@redhat.com>
To: mirimnan017@gmail.com, gcc-patches@gcc.gnu.org
Cc: Immad Mir <mirimmad17@gmail.com>, Immad Mir <mirimmad@outlook.com>
Subject: Re: [PATCH 2/3] analyzer: reorder initialization of state m_invalid in sm-fd.cc [PR106184]
Date: Wed, 06 Jul 2022 11:29:39 -0400 [thread overview]
Message-ID: <0d0420acd29e5b6ab8459d2ff11bc15bbbd27394.camel@redhat.com> (raw)
In-Reply-To: <CY4PR1801MB1910816C25D4D033B6228AFFC6809@CY4PR1801MB1910.namprd18.prod.outlook.com>
On Wed, 2022-07-06 at 19:55 +0530, Immad Mir wrote:
> From: Immad Mir <mirimmad17@gmail.com>
>
> This patch reorders the initialization of state m_invalid in sm-fd.cc
> to conform with standard practice in C++.
Might want to reword to say that the order of the initializers is now
the same as the ordering of the fields in the class decl, or somesuch.
I think I already approved this; it's OK to push this to trunk.
Thanks
Dave
>
>
> gcc/analyzer/ChangeLog:
> PR analyzer/106184
> * sm-fd.cc (fd_state_machine): Change ordering of
> initialization
> of state m_invalid.
>
> Signed-off-by: Immad Mir <mirimmad@outlook.com>
> ---
> gcc/analyzer/sm-fd.cc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/analyzer/sm-fd.cc b/gcc/analyzer/sm-fd.cc
> index 8196d33223a..8e4300b06e2 100644
> --- a/gcc/analyzer/sm-fd.cc
> +++ b/gcc/analyzer/sm-fd.cc
> @@ -551,11 +551,12 @@ fd_state_machine::fd_state_machine (logger
> *logger)
> m_unchecked_read_write (add_state ("fd-unchecked-read-write")),
> m_unchecked_read_only (add_state ("fd-unchecked-read-only")),
> m_unchecked_write_only (add_state ("fd-unchecked-write-only")),
> - m_invalid (add_state ("fd-invalid")),
> m_valid_read_write (add_state ("fd-valid-read-write")),
> m_valid_read_only (add_state ("fd-valid-read-only")),
> m_valid_write_only (add_state ("fd-valid-write-only")),
> - m_closed (add_state ("fd-closed")), m_stop (add_state ("fd-
> stop"))
> + m_invalid (add_state ("fd-invalid")),
> + m_closed (add_state ("fd-closed")),
> + m_stop (add_state ("fd-stop"))
> {
> }
>
next prev parent reply other threads:[~2022-07-06 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220706142543.3790-1-mirimmad@outlook.com>
2022-07-06 14:25 ` Immad Mir
2022-07-06 15:29 ` David Malcolm [this message]
2022-07-06 14:25 ` [PATCH 3/3] analyzer: add a new testcase to demonstrate passsing of a file descriptor to a function that does not emit any warning Immad Mir
2022-07-06 15:37 ` David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d0420acd29e5b6ab8459d2ff11bc15bbbd27394.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mirimmad17@gmail.com \
--cc=mirimmad@outlook.com \
--cc=mirimnan017@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).