* Re: [PATCH] testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452]
2024-01-18 7:39 [PATCH] testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452] Jakub Jelinek
@ 2024-01-18 7:35 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2024-01-18 7:35 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: Uros Bizjak, Tamar Christina, Roger Sayle, gcc-patches
On Thu, 18 Jan 2024, Jakub Jelinek wrote:
> Hi!
>
> From what I can see, this test has been written for a backend fix and
> assumes the loop isn't vectorized (at least, it wasn't when the test was
> added, it contains an early exit), but that is no longer true and because
> of the vectorization it now contains an instruction which the test scans
> for not being present.
>
> I think we should just disable vectorization here.
>
> Regtested on x86_64-linux and i686-linux, ok for trunk?
OK
> 2024-01-18 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/113452
> * gcc.target/i386/sse4_1-stv-1.c: Add -fno-tree-vectorize to
> dg-options.
>
> --- gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c.jj 2022-05-31 11:33:51.603250042 +0200
> +++ gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c 2024-01-17 17:46:21.999689350 +0100
> @@ -1,5 +1,5 @@
> /* { dg-do compile { target ia32 } } */
> -/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign" } */
> +/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign -fno-tree-vectorize" } */
> long long a[1024];
> long long b[1024];
>
>
> Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452]
@ 2024-01-18 7:39 Jakub Jelinek
2024-01-18 7:35 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2024-01-18 7:39 UTC (permalink / raw)
To: Richard Biener, Uros Bizjak, Tamar Christina, Roger Sayle; +Cc: gcc-patches
Hi!
From what I can see, this test has been written for a backend fix and
assumes the loop isn't vectorized (at least, it wasn't when the test was
added, it contains an early exit), but that is no longer true and because
of the vectorization it now contains an instruction which the test scans
for not being present.
I think we should just disable vectorization here.
Regtested on x86_64-linux and i686-linux, ok for trunk?
2024-01-18 Jakub Jelinek <jakub@redhat.com>
PR testsuite/113452
* gcc.target/i386/sse4_1-stv-1.c: Add -fno-tree-vectorize to
dg-options.
--- gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c.jj 2022-05-31 11:33:51.603250042 +0200
+++ gcc/testsuite/gcc.target/i386/sse4_1-stv-1.c 2024-01-17 17:46:21.999689350 +0100
@@ -1,5 +1,5 @@
/* { dg-do compile { target ia32 } } */
-/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign" } */
+/* { dg-options "-O2 -msse4.1 -mstv -mno-stackrealign -fno-tree-vectorize" } */
long long a[1024];
long long b[1024];
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-01-18 7:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-18 7:39 [PATCH] testsuite: Fix up gcc.target/i386/sse4_1-stv-1.c test [PR113452] Jakub Jelinek
2024-01-18 7:35 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).