From: Robin Dapp <rdapp.gcc@gmail.com>
To: pan2.li@intel.com, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, kito.cheng@gmail.com
Subject: Re: [PATCH v1] RISC-V: Revert RVV wv instructions overlap and xfail tests
Date: Fri, 19 Apr 2024 16:54:16 +0200 [thread overview]
Message-ID: <102e32cd-a6ff-47dc-b054-5c87638eb161@gmail.com> (raw)
In-Reply-To: <20240419142901.1585821-1-pan2.li@intel.com>
Hi Pan,
> The RVV register overlap requires both the dest, and src operands.
> Thus the rigister filter in constraint cannot cover the fully sematics
> of the vector register overlap.
I'm not sure I'm following. Did we miss something that should have been
covered? Like only an overlap on the srcs but not the dest?
Are there testcases that fail? If so we should definitely have one.
If something is broken then indeed we should revert it.
But...
> Thus, revert these overlap patches list and xfail the related test
> cases. This patch would like to revert *b3b2799b872*, and the full
> picture of related series are listed as below.
... why not just revert everything and xfail all the tests in a
follow up? Your patch is essentially a revert but doesn't look like
it. I'd rather we let a revert be a revert and adjust the tests
separately so it becomes clear.
Regards
Robin
next prev parent reply other threads:[~2024-04-19 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:29 pan2.li
2024-04-19 14:54 ` Robin Dapp [this message]
2024-04-19 23:24 ` Li, Pan2
2024-04-22 17:20 ` Patrick O'Neill
2024-04-22 22:07 ` 钟居哲
2024-04-23 0:42 ` Palmer Dabbelt
2024-04-23 1:44 ` Li, Pan2
2024-04-25 14:16 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102e32cd-a6ff-47dc-b054-5c87638eb161@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).