From: Patrick O'Neill <patrick@rivosinc.com>
To: "Li, Pan2" <pan2.li@intel.com>, Robin Dapp <rdapp.gcc@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "juzhe.zhong@rivai.ai" <juzhe.zhong@rivai.ai>,
"kito.cheng@gmail.com" <kito.cheng@gmail.com>
Subject: Re: [PATCH v1] RISC-V: Revert RVV wv instructions overlap and xfail tests
Date: Mon, 22 Apr 2024 10:20:45 -0700 [thread overview]
Message-ID: <a990e573-4b24-4514-9935-59dc57730afe@rivosinc.com> (raw)
In-Reply-To: <MW5PR11MB5908152F6EB2B36DD37A39EBA90D2@MW5PR11MB5908.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
Hi Pan,
>> I'm not sure I'm following. Did we miss something that should have been
>> covered? Like only an overlap on the srcs but not the dest?
>> Are there testcases that fail? If so we should definitely have one.
Can you give some additional information on why these reverts are needed?
+1 to the request for a failing testcase if there is one.Patrick
>> If something is broken then indeed we should revert it.
> Yes, we may need to support these in gcc-15.
>
>> ... why not just revert everything and xfail all the tests in a
>> follow up? Your patch is essentially a revert but doesn't look like
>> it. I'd rather we let a revert be a revert and adjust the tests
>> separately so it becomes clear.
> Sure, will revert b3b2799b872 and then file the patch for the xfail tests.
>
> Pan
next prev parent reply other threads:[~2024-04-22 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:29 pan2.li
2024-04-19 14:54 ` Robin Dapp
2024-04-19 23:24 ` Li, Pan2
2024-04-22 17:20 ` Patrick O'Neill [this message]
2024-04-22 22:07 ` 钟居哲
2024-04-23 0:42 ` Palmer Dabbelt
2024-04-23 1:44 ` Li, Pan2
2024-04-25 14:16 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a990e573-4b24-4514-9935-59dc57730afe@rivosinc.com \
--to=patrick@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=pan2.li@intel.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).