From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>, Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: [[deprecated]] on template redecl [PR84542]
Date: Mon, 18 Dec 2023 16:35:10 -0500 [thread overview]
Message-ID: <1602753a-457b-4baa-bcc4-483411f61878@redhat.com> (raw)
In-Reply-To: <ZYCj_sTiyrEZaQC1@redhat.com>
On 12/18/23 14:56, Marek Polacek wrote:
> On Mon, Dec 18, 2023 at 02:50:04PM -0500, Patrick Palka wrote:
>> Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look
>> OK for trunk?
>
> LGTM but...
>
>> -- >8 --
>>
>> The deprecated and unavailable attributes weren't working when used on
>> a template redeclaration ultimately because the corresponding tree flags
>> on the underlying decls weren't being merged across redeclarations.
>>
>> PR c++/84542
>>
>> gcc/cp/ChangeLog:
>>
>> * decl.cc (merge_attribute_bits):
>
> ...this entry is missing. Thanks,
Indeed. OK with that fixed.
prev parent reply other threads:[~2023-12-18 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 19:50 Patrick Palka
2023-12-18 19:56 ` Marek Polacek
2023-12-18 21:35 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602753a-457b-4baa-bcc4-483411f61878@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).