From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix <format> in _GLIBCXX_INLINE_VERSION mode
Date: Sun, 20 Nov 2022 21:45:41 +0100 [thread overview]
Message-ID: <181a331d-ba82-2caf-ce2b-f00665bcafc7@gmail.com> (raw)
In-Reply-To: <CAH6eHdQ8tfbKSSuWd=uCNrJqvHkH3RhCJDmozufeYdH_sbAyxA@mail.gmail.com>
On 19/11/22 14:11, Jonathan Wakely wrote:
> On Sat, 19 Nov 2022 at 13:03, François Dumont via Libstdc++
> <libstdc++@gcc.gnu.org> wrote:
>> Without this qualification I have this in _GLIBCXX_INLINE_VERSION mode:
>>
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649:
>> note: candidate: 'template<class _CharT> bool std::__9::isxdigit(_CharT,
>> const locale&)'
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649:
>> note: template argument deduction/substitution failed:
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540:
>> note: candidate expects 2 arguments, 1 provided
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630:
>> error: no matching function for call to 'isxdigit(const
>> std::__9::basic_string_view<char>::value_type&)'
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649:
>> note: candidate: 'template<class _CharT> bool std::__9::isxdigit(_CharT,
>> const locale&)'
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/locale_facets.h:2649:
>> note: template argument deduction/substitution failed:
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630:
>> note: candidate expects 2 arguments, 1 provided
>> compiler exited with status 1
>> FAIL: 17_intro/headers/c++2020/all_attributes.cc (test for excess errors)
>> Excess errors:
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1540:
>> error: no matching function for call to 'isxdigit(const
>> std::__9::basic_string_view<char>::value_type&)'
>> /home/fdt/dev/gcc/build_versioned_ns/x86_64-pc-linux-gnu/libstdc++-v3/include/format:1630:
>> error: no matching function for call to 'isxdigit(const
>> std::__9::basic_string_view<char>::value_type&)'
>>
>> It sounds like the most reasonable fix as this is how toupper is being
>> called.
> I think the real problem is that include/c_global/cctype is missing
> the NAMESPACE_VERSION macros.
>
> All declarations of std::isxdigit etc should be in the same namespace,
> precisely so we don't need to do this.
Didn't you want to fix it this way then ?
To be honest I was a little bit lost by this code:
#if !__has_builtin(__builtin_toupper)
# include <cctype>
#endif
Looks like cctype is included only for toupper, why not for isxdigit ?
>
>> libstdc++: Add missing std qualification on isxdigit calls
>>
>> libstdc++-v3/ChangeLog
>>
>> * include/std/format: Add std qualification on isxdigit calls.
>>
>> Ok to commit ?
> Yes, OK.
Committed.
next prev parent reply other threads:[~2022-11-20 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 13:02 François Dumont
2022-11-19 13:11 ` Jonathan Wakely
2022-11-20 20:45 ` François Dumont [this message]
2022-11-20 23:17 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=181a331d-ba82-2caf-ce2b-f00665bcafc7@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).