From: Joseph Myers <josmyers@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <rguenther@suse.de>,
gcc-patches@gcc.gnu.org, Jonathan Wakely <jwakely@redhat.com>,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd
Date: Mon, 29 Apr 2024 18:32:59 +0000 (UTC) [thread overview]
Message-ID: <18e6be82-5da6-7148-3ad2-c959a6c31b5d@redhat.com> (raw)
In-Reply-To: <Zi+2TOJn+hQcdtrx@tucnak>
On Mon, 29 Apr 2024, Jakub Jelinek wrote:
> On Mon, Apr 29, 2024 at 01:44:24PM +0000, Joseph Myers wrote:
> > > glibc 2.34 and later doesn't have separate libpthread (libpthread.so.0 is a
> > > dummy shared library with just some symbol versions for compatibility, but
> > > all the pthread_* APIs are in libc.so.6).
> >
> > I suspect this has caused link failures in the glibc testsuite for Hurd,
> > which still has separate libpthread.
> >
> > https://sourceware.org/pipermail/libc-testresults/2024q2/012556.html
>
> So like this then? I can't really test it on Hurd, but will certainly
> test on x86_64-linux/i686-linux.
>
> 2024-04-29 Jakub Jelinek <jakub@redhat.com>
>
> * gthr.h (GTHREAD_USE_WEAK): Don't redefine to 0 for glibc 2.34+
> on GNU Hurd.
Yes, this fixes the problem seem for Hurd with build-many-glibcs.py.
--
Joseph S. Myers
josmyers@redhat.com
prev parent reply other threads:[~2024-04-29 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:23 [PATCH] libgcc: Don't use weakrefs for glibc 2.34 Jakub Jelinek
2024-04-25 18:33 ` Richard Biener
2024-04-29 13:44 ` Joseph Myers
2024-04-29 15:01 ` [PATCH] libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd Jakub Jelinek
2024-04-29 18:32 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18e6be82-5da6-7148-3ad2-c959a6c31b5d@redhat.com \
--to=josmyers@redhat.com \
--cc=fweimer@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jwakely@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).