[patch,avr] PR114975: Better 8-bit parity detection.

[patch,avr] PR114975: Better 8-bit parity detection.

[Georg-Johann Lay]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

Add a combine pattern for parity detection.

Ok for master?

Johann

AVR: target/114975 - Add combine-pattern for __parityqi2.

	PR target/114975
gcc/
	* config/avr/avr.md: Add combine pattern for
	8-bit parity detection.

gcc/testsuite/
	* gcc.target/avr/pr114975-parity.c: New test.

[-- Attachment #2: pr114975-parity.diff --]
[-- Type: text/x-patch, Size: 1527 bytes --]

diff --git a/gcc/config/avr/avr.md b/gcc/config/avr/avr.md
index 97f42be7729..d4fcff46123 100644
--- a/gcc/config/avr/avr.md
+++ b/gcc/config/avr/avr.md
@@ -8418,7 +8418,22 @@ (define_insn_and_split "*parityhi2"
    (set (match_dup 0)
         (reg:HI 24))])
 
-(define_insn_and_split "*parityqihi2"
+(define_insn_and_split "*parityqihi2.1"
+  [(set (match_operand:HI 0 "register_operand"            "=r")
+        (zero_extend:HI
+         (parity:QI (match_operand:QI 1 "register_operand" "r"))))
+   (clobber (reg:HI 24))]
+  "!reload_completed"
+  { gcc_unreachable(); }
+  "&& 1"
+  [(set (reg:QI 24)
+        (match_dup 1))
+   (set (reg:HI 24)
+        (zero_extend:HI (parity:QI (reg:QI 24))))
+   (set (match_dup 0)
+        (reg:HI 24))])
+
+(define_insn_and_split "*parityqihi2.2"
   [(set (match_operand:HI 0 "register_operand"           "=r")
         (parity:HI (match_operand:QI 1 "register_operand" "r")))
    (clobber (reg:HI 24))]
diff --git a/gcc/testsuite/gcc.target/avr/pr114975-parity.c b/gcc/testsuite/gcc.target/avr/pr114975-parity.c
new file mode 100644
index 00000000000..767ced0a464
--- /dev/null
+++ b/gcc/testsuite/gcc.target/avr/pr114975-parity.c
@@ -0,0 +1,17 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-Os" } */
+
+typedef __UINT8_TYPE__ uint8_t;
+
+uint8_t use_pary1 (int y, uint8_t x)
+{
+    return 1 + __builtin_parity (x);
+}
+
+uint8_t use_pary2 (uint8_t x)
+{
+	x += 1;
+    return 1 - __builtin_parity (x);
+}
+
+/* { dg-final { scan-assembler-times "__parityqi2" 2 } } */

Re: [patch,avr] PR114975: Better 8-bit parity detection.

[Jeff Law]

On 5/7/24 11:23 AM, Georg-Johann Lay wrote:
> Add a combine pattern for parity detection.
> 
> Ok for master?
> 
> Johann
> 
> AVR: target/114975 - Add combine-pattern for __parityqi2.
> 
>      PR target/114975
> gcc/
>      * config/avr/avr.md: Add combine pattern for
>      8-bit parity detection.
> 
> gcc/testsuite/
>      * gcc.target/avr/pr114975-parity.c: New test.
OK
jeff