From: Andrew Stubbs <ams@codesourcery.com>
To: Thomas Schwinge <thomas@codesourcery.com>,
<gcc-patches@gcc.gnu.org>,
Tobias Burnus <tobias@codesourcery.com>
Subject: Re: [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory)
Date: Mon, 27 Mar 2023 13:01:11 +0100 [thread overview]
Message-ID: <1a37516b-7584-1c45-8f6f-17a121bbcfc2@codesourcery.com> (raw)
In-Reply-To: <878rfiqvtn.fsf@euler.schwinge.homeip.net>
On 27/03/2023 12:26, Thomas Schwinge wrote:
> Hi!
>
> On 2023-03-27T09:27:31+0000, "Stubbs, Andrew" <andrew.stubbs@siemens.com> wrote:
>>> -----Original Message-----
>>> From: Thomas Schwinge <thomas@codesourcery.com>
>>> Sent: 24 March 2023 15:50
>>>
>>> On 2022-01-04T15:32:17+0000, Andrew Stubbs <ams@codesourcery.com>
>>> wrote:
>>>> This patch implements the OpenMP pinned memory trait [...]
>>>
>>> I figure it may be helpful to document the current og12 state of affairs; does
>>> the attached "libgomp: Document OpenMP 'pinned' memory" look good to
>>> you?
>>
>> I don't really know what "allocated via the device" means?
>
> Heh, you're right.
>
>> I mean, I presume you mean "via CUDA", but I don't think this is obvious to the average reader.
>> Maybe "allocation is optimized for the device" or some such thing?
>
> As we're in sections that are documenting GCN vs. nvptx specifics, we
> might indeed call out which exact interfaces we're using.
>
> How's the updated "libgomp: Document OpenMP 'pinned' memory", see
> attached?
LGTM, FWIW.
Andrew
prev parent reply other threads:[~2023-03-27 12:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 15:32 [PATCH] libgomp, openmp: pinned memory Andrew Stubbs
2022-01-04 15:55 ` Jakub Jelinek
2022-01-04 16:58 ` Andrew Stubbs
2022-01-04 18:28 ` Jakub Jelinek
2022-01-04 18:47 ` Jakub Jelinek
2022-01-05 17:07 ` Andrew Stubbs
2022-01-13 13:53 ` Andrew Stubbs
2022-06-07 11:05 ` Andrew Stubbs
2022-06-07 12:10 ` Jakub Jelinek
2022-06-07 12:28 ` Andrew Stubbs
2022-06-07 12:40 ` Jakub Jelinek
2022-06-09 9:38 ` Thomas Schwinge
2022-06-09 10:09 ` Tobias Burnus
2022-06-09 10:22 ` Stubbs, Andrew
2022-06-09 10:31 ` Stubbs, Andrew
2023-02-16 15:32 ` Attempt to register OpenMP pinned memory using a device instead of 'mlock' (was: [PATCH] libgomp, openmp: pinned memory) Thomas Schwinge
2023-02-16 16:17 ` Stubbs, Andrew
2023-02-16 22:06 ` [og12] " Thomas Schwinge
2023-02-17 8:12 ` Thomas Schwinge
2023-02-20 9:48 ` Andrew Stubbs
2023-02-20 13:53 ` [og12] Attempt to not just register but allocate OpenMP pinned memory using a device (was: [og12] Attempt to register OpenMP pinned memory using a device instead of 'mlock') Thomas Schwinge
2023-02-10 15:11 ` [PATCH] libgomp, openmp: pinned memory Thomas Schwinge
2023-02-10 15:55 ` Andrew Stubbs
2023-02-16 21:39 ` [og12] Clarify/verify OpenMP 'omp_calloc' zero-initialization for pinned memory (was: [PATCH] libgomp, openmp: pinned memory) Thomas Schwinge
2023-03-24 15:49 ` [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory Thomas Schwinge
2023-03-27 9:27 ` Stubbs, Andrew
2023-03-27 11:26 ` [og12] libgomp: Document OpenMP 'pinned' memory (was: [PATCH] libgomp, openmp: pinned memory) Thomas Schwinge
2023-03-27 12:01 ` Andrew Stubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a37516b-7584-1c45-8f6f-17a121bbcfc2@codesourcery.com \
--to=ams@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).