From: Jeff Law <jeffreyalaw@gmail.com>
To: Richard Biener <rguenther@suse.de>, gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: Re: [PATCH] tree-optimization/110434 - avoid <retval> ={v} {CLOBBER} from NRV
Date: Wed, 28 Jun 2023 08:19:07 -0600 [thread overview]
Message-ID: <1cb42ba7-effe-f477-2a1a-2f6c59ebbce9@gmail.com> (raw)
In-Reply-To: <20230628102159.84C093858412@sourceware.org>
On 6/28/23 04:21, Richard Biener via Gcc-patches wrote:
> When NRV replaces a local variable with <retval> it also replaces
> occurences in clobbers. This leads to <retval> being clobbered
> before the return of it which is strictly invalid but harmless in
> practice since there's no pass after NRV which would remove
> earlier stores.
>
> The following fixes this nevertheless.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
>
> Thanks,
> Richard.
>
> PR tree-optimization/110434
> * tree-nrv.cc (pass_nrv::execute): Remove CLOBBERs of
> VAR we replace with <retval>.
OK.
jeff
next parent reply other threads:[~2023-06-28 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230628102159.84C093858412@sourceware.org>
2023-06-28 14:19 ` Jeff Law [this message]
[not found] <20230628102150.620743857B8E@sourceware.org>
2023-06-28 10:37 ` Jakub Jelinek
2023-06-28 12:32 ` Richard Biener
2023-06-28 12:38 ` Jakub Jelinek
2023-06-28 10:21 Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb42ba7-effe-f477-2a1a-2f6c59ebbce9@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).