public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Basile Starynkevitch <basile@starynkevitch.net>
To: Pierre Vittet <piervit@pvittet.com>
Cc: gcc-patches@gcc.gnu.org, tromey@redhat.com, joseph@codesourcery.com
Subject: Re: [PATCH] c-pragma: adding a data field to pragma_handler
Date: Fri, 03 Jun 2011 15:48:00 -0000	[thread overview]
Message-ID: <20110603174741.f3684596.basile@starynkevitch.net> (raw)
In-Reply-To: <4DE8FE4D.6050404@pvittet.com>

On Fri, 03 Jun 2011 17:31:25 +0200
Pierre Vittet <piervit@pvittet.com> wrote:

> Thank you for your answer!
> 
> I send you a new patch
> I have corrected the errors you raised.
> 
> I have make my patch compatible with the old use of c_register_pragma 
> and c_register_pragma_with_expansion.

I find the patch quite interesting, but I cannot approve it.

 void
+c_register_pragma_with_expansion_and_data (const char *space, const char *name,
+				                                   pragma_handler_2arg handler,
+                                           void * data)

Perhaps there are some spaces (vs tabs) issues here.

Cheers
-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

  reply	other threads:[~2011-06-03 15:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 16:55 Pierre
2011-06-01 17:54 ` Basile Starynkevitch
2011-06-02 17:52 ` Tom Tromey
2011-06-03 15:32   ` Pierre Vittet
2011-06-03 15:48     ` Basile Starynkevitch [this message]
2011-06-03 20:25       ` Pierre Vittet
2011-06-08 21:35     ` Pierre Vittet
2011-06-09  7:21       ` Basile Starynkevitch
2011-06-09  9:08         ` Pierre Vittet
2011-06-09 14:53           ` Joseph S. Myers
2011-06-10  9:17             ` Pierre Vittet
2011-06-10 14:02               ` Joseph S. Myers
2011-06-10 16:15                 ` Pierre Vittet
2011-06-15 15:10                   ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603174741.f3684596.basile@starynkevitch.net \
    --to=basile@starynkevitch.net \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=piervit@pvittet.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).