From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Pierre Vittet <piervit@pvittet.com>
Cc: gcc-patches@gcc.gnu.org, tromey@redhat.com,
Basile Starynkevitch <basile@starynkevitch.net>
Subject: Re: [PATCH] c-pragma: adding a data field to pragma_handler
Date: Thu, 09 Jun 2011 14:53:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106091432530.10651@digraph.polyomino.org.uk> (raw)
In-Reply-To: <4DF08B94.1010804@pvittet.com>
Thanks for this patch. You need to adjust the formatting of the comments
to match the existing style (in particular, indentation of second and
subsequent lines of comments, and watch out for spelling errors (exemple,
abstact). For a struct, the explanations of individual fields should be
in the comments on those fields rather than at the top of the struct. The
comment on c_register_pragma_with_data should refer to
c_register_pragma_with_expansion_and_data rather than
c_register_pragma_with_expansion.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-06-09 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 16:55 Pierre
2011-06-01 17:54 ` Basile Starynkevitch
2011-06-02 17:52 ` Tom Tromey
2011-06-03 15:32 ` Pierre Vittet
2011-06-03 15:48 ` Basile Starynkevitch
2011-06-03 20:25 ` Pierre Vittet
2011-06-08 21:35 ` Pierre Vittet
2011-06-09 7:21 ` Basile Starynkevitch
2011-06-09 9:08 ` Pierre Vittet
2011-06-09 14:53 ` Joseph S. Myers [this message]
2011-06-10 9:17 ` Pierre Vittet
2011-06-10 14:02 ` Joseph S. Myers
2011-06-10 16:15 ` Pierre Vittet
2011-06-15 15:10 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106091432530.10651@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=basile@starynkevitch.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=piervit@pvittet.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).