From: dnovillo@google.com (Diego Novillo)
To: reply@codereview.appspotmail.com, gchare@google.com,
crowl@google.com, gcc-patches@gcc.gnu.org
Subject: [pph] Do not emit PCH if generating PPH (issue4591061)
Date: Thu, 09 Jun 2011 18:55:00 -0000 [thread overview]
Message-ID: <20110609184955.794601DA1CD@topo.tor.corp.google.com> (raw)
We were trying to generate PCH and PPH information at the same time.
We never noticed because PPH is generated after PCH, so we were just
clobbering over the previous dump.
Found it by accident while debugging a GC ICE. This should make
testing slightly faster.
Committed to the branch.
* lang-specs.h (@c++-header): Do not emit PCH if any -fpph flag is
present.
diff --git a/gcc/cp/lang-specs.h b/gcc/cp/lang-specs.h
index a73aba3..9943446 100644
--- a/gcc/cp/lang-specs.h
+++ b/gcc/cp/lang-specs.h
@@ -48,8 +48,8 @@ along with GCC; see the file COPYING3. If not see
cc1plus %{save-temps*|no-integrated-cpp:-fpreprocessed %{save-temps*:%b.ii} %{!save-temps*:%g.ii}}\
%{!save-temps*:%{!no-integrated-cpp:%(cpp_unique_options)}}\
%(cc1_options) %2\
- %{!fsyntax-only:%{!fdump-ada-spec*:-o %g.s %{!o*:--output-pch=%i.gch}\
- %W{o*:--output-pch=%*}}%V}}}}",
+ %{!fsyntax-only:%{!fpph*:%{!fdump-ada-spec*:-o %g.s %{!o*:--output-pch=%i.gch}\
+ %W{o*:--output-pch=%*}}}%V}}}}",
CPLUSPLUS_CPP_SPEC, 0, 0},
{"@c++",
"%{E|M|MM:cc1plus -E %(cpp_options) %2 %(cpp_debug_options)}\
--
This patch is available for review at http://codereview.appspot.com/4591061
next reply other threads:[~2011-06-09 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 18:55 Diego Novillo [this message]
2011-06-10 15:53 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609184955.794601DA1CD@topo.tor.corp.google.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).