public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hongjiu.lu@intel.com>
To: gcc-patches@gcc.gnu.org
Subject: PATCH [5/n]: Prepare x32: PR middle-end/48016: Inconsistency in non-local goto save area
Date: Sat, 11 Jun 2011 16:22:00 -0000	[thread overview]
Message-ID: <20110611160548.GA20036@intel.com> (raw)

Hi,

We are very inconsistent when saving and restoring non-local goto save
area.  See:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48016

for detailed analysis.  OK for trunk?

Thanks.


H.J.
---
2011-06-07  H.J. Lu  <hongjiu.lu@intel.com>

	PR middle-end/48016
	* explow.c (emit_stack_save): Adjust mode of stack save area.

	* function.c (expand_function_start): Properly store frame
	pointer for non-local goto.

diff --git a/gcc/explow.c b/gcc/explow.c
index 7387dad..b343bf8 100644
--- a/gcc/explow.c
+++ b/gcc/explow.c
@@ -1035,6 +1030,14 @@ emit_stack_save (enum save_level save_level, rtx *psave)
   do_pending_stack_adjust ();
   if (sa != 0)
     sa = validize_mem (sa);
+  /* FIXME: update_nonlocal_goto_save_area may pass SA in the wrong mode.  */
+  if (GET_MODE (sa) != mode)
+    {
+      gcc_assert (ptr_mode != Pmode
+		  && GET_MODE (sa) == ptr_mode
+		  && mode == Pmode);
+      sa = adjust_address (sa, mode, 0); 
+    }
   emit_insn (fcn (sa, stack_pointer_rtx));
 }
 
diff --git a/gcc/function.c b/gcc/function.c
index 30cc9ff..47fd5b7 100644
--- a/gcc/function.c
+++ b/gcc/function.c
@@ -4779,7 +4779,7 @@ expand_function_start (tree subr)
 		       cfun->nonlocal_goto_save_area,
 		       integer_zero_node, NULL_TREE, NULL_TREE);
       r_save = expand_expr (t_save, NULL_RTX, VOIDmode, EXPAND_WRITE);
-      r_save = convert_memory_address (Pmode, r_save);
+      r_save = adjust_address (r_save, Pmode, 0);
 
       emit_move_insn (r_save, targetm.builtin_setjmp_frame_value ());
       update_nonlocal_goto_save_area ();

             reply	other threads:[~2011-06-11 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-11 16:22 H.J. Lu [this message]
2011-06-15 14:37 ` Michael Matz
2011-06-15 15:10   ` H.J. Lu
     [not found]     ` <Pine.LNX.4.64.1106151659200.17115@wotan.suse.de>
2011-06-16  6:41       ` H.J. Lu
2011-06-16  8:02         ` Richard Guenther
2011-06-16 17:59           ` H.J. Lu
2011-06-25 16:20             ` H.J. Lu
2011-06-29 15:25               ` H.J. Lu
2011-06-29 17:03                 ` Michael Matz
2011-06-30 18:10                   ` H.J. Lu
2011-07-01  8:01                     ` Richard Guenther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110611160548.GA20036@intel.com \
    --to=hongjiu.lu@intel.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).