From: Michael Matz <matz@suse.de>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH [5/n]: Prepare x32: PR middle-end/48016: Inconsistency in non-local goto save area
Date: Wed, 15 Jun 2011 14:37:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1106151607290.17115@wotan.suse.de> (raw)
In-Reply-To: <20110611160548.GA20036@intel.com>
Hi,
On Sat, 11 Jun 2011, H.J. Lu wrote:
> We are very inconsistent when saving and restoring non-local goto save
> area. See:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48016
>
> for detailed analysis. OK for trunk?
> + /* FIXME: update_nonlocal_goto_save_area may pass SA in the wrong mode. */
> + if (GET_MODE (sa) != mode)
> + {
> + gcc_assert (ptr_mode != Pmode
> + && GET_MODE (sa) == ptr_mode
> + && mode == Pmode);
> + sa = adjust_address (sa, mode, 0);
> + }
That may be appropriate for a branch, but trunk shouldn't contain FIXMEs
that explain how something should be fixed, instead that something should
be carried out. I.e. just fix update_nonlocal_goto_save_area.
Ciao,
Michael.
next prev parent reply other threads:[~2011-06-15 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 16:22 H.J. Lu
2011-06-15 14:37 ` Michael Matz [this message]
2011-06-15 15:10 ` H.J. Lu
[not found] ` <Pine.LNX.4.64.1106151659200.17115@wotan.suse.de>
2011-06-16 6:41 ` H.J. Lu
2011-06-16 8:02 ` Richard Guenther
2011-06-16 17:59 ` H.J. Lu
2011-06-25 16:20 ` H.J. Lu
2011-06-29 15:25 ` H.J. Lu
2011-06-29 17:03 ` Michael Matz
2011-06-30 18:10 ` H.J. Lu
2011-07-01 8:01 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1106151607290.17115@wotan.suse.de \
--to=matz@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).