From: Eric Botcazou <ebotcazou@adacore.com>
To: Mike Stump <mikestump@comcast.net>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Remove SETJMP_VIA_SAVE_AREA support
Date: Mon, 23 Apr 2012 10:06:00 -0000 [thread overview]
Message-ID: <201204231204.59469.ebotcazou@adacore.com> (raw)
In-Reply-To: <15A01AEA-2E50-44A8-B94D-C2D18746190C@comcast.net>
> You do know that at least rtl hoisting is dependent upon calls_setjmp being
> set, right? :-(
Sure, clearly a straightforward dependency. ;-)
> This part breaks my port. I think you read the comment and thought it was
> exhaustive, I don't believe it is.
I think it should, though. __builtin_setjmp doesn't need the calls_setjmp big
hammer, since everything is supposed to be exposed in the IR.
> Any objection to putting it back, or, would you like me to drill down on
> rtl hoisting?
Yes, the problem needs to be understood first. This change broke something for
Darwin too and the fix was a one-liner in the back-end:
http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00351.html
--
Eric Botcazou
prev parent reply other threads:[~2012-04-23 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 10:49 Eric Botcazou
2011-06-02 21:53 ` Eric Botcazou
2011-06-09 7:15 ` Hans-Peter Nilsson
2011-06-09 13:06 ` Eric Botcazou
2011-06-10 3:52 ` Hans-Peter Nilsson
2011-06-10 7:19 ` Eric Botcazou
2012-04-18 19:19 ` Mike Stump
2012-04-23 10:06 ` Eric Botcazou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204231204.59469.ebotcazou@adacore.com \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).