From: Mike Stump <mikestump@comcast.net>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: Remove SETJMP_VIA_SAVE_AREA support
Date: Wed, 18 Apr 2012 19:19:00 -0000 [thread overview]
Message-ID: <15A01AEA-2E50-44A8-B94D-C2D18746190C@comcast.net> (raw)
In-Reply-To: <201106021241.49426.ebotcazou@adacore.com>
On Jun 2, 2011, at 3:41 AM, Eric Botcazou wrote:
> This removes the (undocumented) support for SETJMP_VIA_SAVE_AREA from the
> compiler.
> 2011-06-02 Eric Botcazou <ebotcazou@adacore.com>
> * builtins.c (expand_builtin_setjmp_setup): Do not set calls_setjmp.
> --- builtins.c (revision 174559)
> +++ builtins.c (working copy)
> @@ -806,10 +806,6 @@ expand_builtin_setjmp_setup (rtx buf_add
> emit_insn (gen_builtin_setjmp_setup (buf_addr));
> #endif
>
> - /* Tell optimize_save_area_alloca that extra work is going to
> - need to go on during alloca. */
> - cfun->calls_setjmp = 1;
> -
> /* We have a nonlocal label. */
> cfun->has_nonlocal_label = 1;
> }
You do know that at least rtl hoisting is dependent upon calls_setjmp being set, right? :-(
This part breaks my port. I think you read the comment and thought it was exhaustive, I don't believe it is.
Any objection to putting it back, or, would you like me to drill down on rtl hoisting?
next prev parent reply other threads:[~2012-04-18 19:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 10:49 Eric Botcazou
2011-06-02 21:53 ` Eric Botcazou
2011-06-09 7:15 ` Hans-Peter Nilsson
2011-06-09 13:06 ` Eric Botcazou
2011-06-10 3:52 ` Hans-Peter Nilsson
2011-06-10 7:19 ` Eric Botcazou
2012-04-18 19:19 ` Mike Stump [this message]
2012-04-23 10:06 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15A01AEA-2E50-44A8-B94D-C2D18746190C@comcast.net \
--to=mikestump@comcast.net \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).