[PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 2252 bytes --]

Hi.

Following patch adds "native" as a possible option for -march value on i386 target.
I have similar patches for other targets. Would it be possible to install the
patch in current stage?

Before:
$ ./xgcc -B. -march=abcdef /tmp/empty.c
cc1: error: bad value (‘abcdef’) for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake bonnell atom silvermont slm knl knm x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 btver1 btver2

After:
$ ./xgcc -B. -march=abcdef /tmp/empty.c
cc1: error: bad value (‘abcdef’) for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake bonnell atom silvermont slm knl knm x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 btver1 btver2 native

$ ./xgcc -B. -march=native2 /tmp/empty.c
cc1: error: bad value (‘native2’) for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake bonnell atom silvermont slm knl knm x86-64 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 btver1 btver2 native; did you mean ‘native’?

Ready for trunk after tests?
Thanks
Martin

gcc/ChangeLog:

2018-02-20  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* config/i386/i386.c (ix86_option_override_internal):
	Add "native" as a possible value.
---
 gcc/config/i386/i386.c | 3 +++
 1 file changed, 3 insertions(+)



[-- Attachment #2: 0001-Add-native-as-a-valid-option-value-for-march-on-i386.patch --]
[-- Type: text/x-patch, Size: 554 bytes --]

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index d54e7301e84..361d4df2663 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
 		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
 	  candidates.safe_push (processor_alias_table[i].name);
 
+      /* Add also "native" as possible value.  */
+      candidates.safe_push ("native");
+
       char *s;
       const char *hint
 	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Richard Sandiford]

Martin Liška <mliska@suse.cz> writes:
> Hi.
>
> Following patch adds "native" as a possible option for -march value on
> i386 target.  I have similar patches for other targets. Would it be
> possible to install the patch in current stage?

[...]

> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index d54e7301e84..361d4df2663 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
>  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>  	  candidates.safe_push (processor_alias_table[i].name);
>  
> +      /* Add also "native" as possible value.  */
> +      candidates.safe_push ("native");
> +
>        char *s;
>        const char *hint
>  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);

We should probably only do this if the driver supports -march=native.
I think for x86 that means HAVE_LOCAL_CPU_DETECT.

Thanks,
Richard

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Richard Sandiford]

Jakub Jelinek <jakub@redhat.com> writes:
> On Tue, Feb 20, 2018 at 03:58:07PM +0000, Richard Sandiford wrote:
>> Martin Liška <mliska@suse.cz> writes:
>> > Hi.
>> >
>> > Following patch adds "native" as a possible option for -march value on
>> > i386 target.  I have similar patches for other targets. Would it be
>> > possible to install the patch in current stage?
>> 
>> [...]
>> 
>> > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>> > index d54e7301e84..361d4df2663 100644
>> > --- a/gcc/config/i386/i386.c
>> > +++ b/gcc/config/i386/i386.c
>> > @@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
>> >  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>> >  	  candidates.safe_push (processor_alias_table[i].name);
>> >  
>> > +      /* Add also "native" as possible value.  */
>> > +      candidates.safe_push ("native");
>> > +
>> >        char *s;
>> >        const char *hint
>> >  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
>> 
>> We should probably only do this if the driver supports -march=native.
>> I think for x86 that means HAVE_LOCAL_CPU_DETECT.
>
> Isn't the option available always?  It just doesn't do anything if
> /* If we are compiling with GCC where %EBX register is fixed, then the
>    driver will just ignore -march and -mtune "native" target and will leave
>    to the newly built compiler to generate code for its default target.  */

It's only available for x86 hosts:

/* -march=native handling only makes sense with compiler running on
   an x86 or x86_64 chip.  If changing this condition, also change
   the condition in driver-i386.c.  */
#if defined(__i386__) || defined(__x86_64__)
/* In driver-i386.c.  */
extern const char *host_detect_local_cpu (int argc, const char **argv);
#define EXTRA_SPEC_FUNCTIONS \
  { "local_cpu_detect", host_detect_local_cpu },
#define HAVE_LOCAL_CPU_DETECT
#endif

Non-native hosts are obviously a niche case for x86, but it still
seems better to be consistent.

Richard

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Martin Liška]

On 02/20/2018 05:19 PM, Richard Sandiford wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
>> On Tue, Feb 20, 2018 at 03:58:07PM +0000, Richard Sandiford wrote:
>>> Martin Liška <mliska@suse.cz> writes:
>>>> Hi.
>>>>
>>>> Following patch adds "native" as a possible option for -march value on
>>>> i386 target.  I have similar patches for other targets. Would it be
>>>> possible to install the patch in current stage?
>>>
>>> [...]
>>>
>>>> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>>>> index d54e7301e84..361d4df2663 100644
>>>> --- a/gcc/config/i386/i386.c
>>>> +++ b/gcc/config/i386/i386.c
>>>> @@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
>>>>  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>>>>  	  candidates.safe_push (processor_alias_table[i].name);
>>>>  
>>>> +      /* Add also "native" as possible value.  */
>>>> +      candidates.safe_push ("native");
>>>> +
>>>>        char *s;
>>>>        const char *hint
>>>>  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
>>>
>>> We should probably only do this if the driver supports -march=native.
>>> I think for x86 that means HAVE_LOCAL_CPU_DETECT.
>>
>> Isn't the option available always?  It just doesn't do anything if
>> /* If we are compiling with GCC where %EBX register is fixed, then the
>>    driver will just ignore -march and -mtune "native" target and will leave
>>    to the newly built compiler to generate code for its default target.  */
> 
> It's only available for x86 hosts:
> 
> /* -march=native handling only makes sense with compiler running on
>    an x86 or x86_64 chip.  If changing this condition, also change
>    the condition in driver-i386.c.  */
> #if defined(__i386__) || defined(__x86_64__)
> /* In driver-i386.c.  */
> extern const char *host_detect_local_cpu (int argc, const char **argv);
> #define EXTRA_SPEC_FUNCTIONS \
>   { "local_cpu_detect", host_detect_local_cpu },
> #define HAVE_LOCAL_CPU_DETECT
> #endif
> 
> Non-native hosts are obviously a niche case for x86, but it still
> seems better to be consistent.
> 
> Richard
> 

So would it enough to wrap 'candidates.safe_push ("native");' by
#ifdef HAVE_LOCAL_CPU_DETECT
?

Thanks,
Martin

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Jakub Jelinek]

On Tue, Feb 20, 2018 at 03:58:07PM +0000, Richard Sandiford wrote:
> Martin Liška <mliska@suse.cz> writes:
> > Hi.
> >
> > Following patch adds "native" as a possible option for -march value on
> > i386 target.  I have similar patches for other targets. Would it be
> > possible to install the patch in current stage?
> 
> [...]
> 
> > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> > index d54e7301e84..361d4df2663 100644
> > --- a/gcc/config/i386/i386.c
> > +++ b/gcc/config/i386/i386.c
> > @@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
> >  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
> >  	  candidates.safe_push (processor_alias_table[i].name);
> >  
> > +      /* Add also "native" as possible value.  */
> > +      candidates.safe_push ("native");
> > +
> >        char *s;
> >        const char *hint
> >  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
> 
> We should probably only do this if the driver supports -march=native.
> I think for x86 that means HAVE_LOCAL_CPU_DETECT.

Isn't the option available always?  It just doesn't do anything if
/* If we are compiling with GCC where %EBX register is fixed, then the
   driver will just ignore -march and -mtune "native" target and will leave
   to the newly built compiler to generate code for its default target.  */

	Jakub

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

On 02/20/2018 05:26 PM, Martin Liška wrote:
> On 02/20/2018 05:19 PM, Richard Sandiford wrote:
>> Jakub Jelinek <jakub@redhat.com> writes:
>>> On Tue, Feb 20, 2018 at 03:58:07PM +0000, Richard Sandiford wrote:
>>>> Martin Liška <mliska@suse.cz> writes:
>>>>> Hi.
>>>>>
>>>>> Following patch adds "native" as a possible option for -march value on
>>>>> i386 target.  I have similar patches for other targets. Would it be
>>>>> possible to install the patch in current stage?
>>>>
>>>> [...]
>>>>
>>>>> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
>>>>> index d54e7301e84..361d4df2663 100644
>>>>> --- a/gcc/config/i386/i386.c
>>>>> +++ b/gcc/config/i386/i386.c
>>>>> @@ -4193,6 +4193,9 @@ ix86_option_override_internal (bool main_args_p,
>>>>>  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>>>>>  	  candidates.safe_push (processor_alias_table[i].name);
>>>>>  
>>>>> +      /* Add also "native" as possible value.  */
>>>>> +      candidates.safe_push ("native");
>>>>> +
>>>>>        char *s;
>>>>>        const char *hint
>>>>>  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
>>>>
>>>> We should probably only do this if the driver supports -march=native.
>>>> I think for x86 that means HAVE_LOCAL_CPU_DETECT.
>>>
>>> Isn't the option available always?  It just doesn't do anything if
>>> /* If we are compiling with GCC where %EBX register is fixed, then the
>>>    driver will just ignore -march and -mtune "native" target and will leave
>>>    to the newly built compiler to generate code for its default target.  */
>>
>> It's only available for x86 hosts:
>>
>> /* -march=native handling only makes sense with compiler running on
>>    an x86 or x86_64 chip.  If changing this condition, also change
>>    the condition in driver-i386.c.  */
>> #if defined(__i386__) || defined(__x86_64__)
>> /* In driver-i386.c.  */
>> extern const char *host_detect_local_cpu (int argc, const char **argv);
>> #define EXTRA_SPEC_FUNCTIONS \
>>   { "local_cpu_detect", host_detect_local_cpu },
>> #define HAVE_LOCAL_CPU_DETECT
>> #endif
>>
>> Non-native hosts are obviously a niche case for x86, but it still
>> seems better to be consistent.
>>
>> Richard
>>
> 
> So would it enough to wrap 'candidates.safe_push ("native");' by
> #ifdef HAVE_LOCAL_CPU_DETECT
> ?
> 
> Thanks,
> Martin
> 

There's updated version of the patch I've just tested.

Martin

[-- Attachment #2: 0003-Add-native-as-a-valid-option-value-for-march-on-i386.patch --]
[-- Type: text/x-patch, Size: 1081 bytes --]

From 8f1783a9017ec06c578fd644e46168ec5763d5ca Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 20 Feb 2018 14:21:05 +0100
Subject: [PATCH 3/3] Add "native" as a valid option value for -march= on i386
 (PR driver/83193).

gcc/ChangeLog:

2018-02-20  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* config/i386/i386.c (ix86_option_override_internal):
	Add "native" as a possible value.
---
 gcc/config/i386/i386.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index d54e7301e84..9f2c5218ae5 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -4193,6 +4193,11 @@ ix86_option_override_internal (bool main_args_p,
 		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
 	  candidates.safe_push (processor_alias_table[i].name);
 
+#ifdef HAVE_LOCAL_CPU_DETECT
+      /* Add also "native" as possible value.  */
+      candidates.safe_push ("native");
+#endif
+
       char *s;
       const char *hint
 	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
-- 
2.16.1

Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 79 bytes --]

Hi.

This is equivalent patch for ARM target.

Ready for trunk?
Thanks,
Martin

[-- Attachment #2: 0001-Add-native-as-a-valid-option-value-for-march-on-arm-.patch --]
[-- Type: text/x-patch, Size: 1810 bytes --]

From 656a883bc5239439ba80743f15a8df704501ee71 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 20 Feb 2018 14:09:22 +0100
Subject: [PATCH 1/3] Add "native" as a valid option value for -march= on arm
 (PR driver/83193).

gcc/ChangeLog:

2018-02-20  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* common/config/arm/arm-common.c (arm_print_hint_for_arch_option):
	Add "native" as a possible value.
	* config/arm/arm.h (HAVE_LOCAL_CPU_DETECT): Define the macro
	when native cpu detection is available.
---
 gcc/common/config/arm/arm-common.c | 6 ++++++
 gcc/config/arm/arm.h               | 1 +
 2 files changed, 7 insertions(+)

diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c
index fc585e0b0ee..50f0bad3e36 100644
--- a/gcc/common/config/arm/arm-common.c
+++ b/gcc/common/config/arm/arm-common.c
@@ -353,6 +353,12 @@ arm_print_hint_for_arch_option (const char *target,
   auto_vec<const char*> candidates;
   for (; list->common.name != NULL; list++)
     candidates.safe_push (list->common.name);
+
+#ifdef HAVE_LOCAL_CPU_DETECT
+  /* Add also "native" as possible value.  */
+  candidates.safe_push ("native");
+#endif
+
   char *s;
   const char *hint = candidates_list_and_hint (target, s, candidates);
   if (hint)
diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h
index 6f3c4f461b9..bbf3937a592 100644
--- a/gcc/config/arm/arm.h
+++ b/gcc/config/arm/arm.h
@@ -2194,6 +2194,7 @@ extern const char *arm_target_thumb_only (int argc, const char **argv);
    an ARM chip.  */
 #if defined(__arm__)
 extern const char *host_detect_local_cpu (int argc, const char **argv);
+#define HAVE_LOCAL_CPU_DETECT
 # define MCPU_MTUNE_NATIVE_FUNCTIONS			\
   { "local_cpu_detect", host_detect_local_cpu },
 # define MCPU_MTUNE_NATIVE_SPECS				\
-- 
2.16.1

[PATCH] Add "native" as a valid option value for -march= on aarch64 (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 139 bytes --]

Hi.

This is equivalent patch for aarch64 target. I've tested that both as cross
compiler and native one.

Ready for trunk?
Thanks,
Martin

[-- Attachment #2: 0002-Add-native-as-a-valid-option-value-for-march-on-aarc.patch --]
[-- Type: text/x-patch, Size: 1850 bytes --]

From 4fbe17099f8618ddd6a4de2d269ecb6f99625927 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 20 Feb 2018 14:14:25 +0100
Subject: [PATCH 2/3] Add "native" as a valid option value for -march= on
 aarch64 (PR driver/83193).

gcc/ChangeLog:

2018-02-20  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* config/aarch64/aarch64.c (aarch64_print_hint_for_core_or_arch):
	Add "native" as a possible value.
	* config/aarch64/aarch64.h (HAVE_LOCAL_CPU_DETECT):  Define
	the macro when native cpu detection is available.
---
 gcc/config/aarch64/aarch64.c | 7 +++++++
 gcc/config/aarch64/aarch64.h | 1 +
 2 files changed, 8 insertions(+)

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index e1fb87f047f..33c90ef02dc 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -10628,6 +10628,13 @@ aarch64_print_hint_for_core_or_arch (const char *str, bool arch)
   const struct processor *entry = arch ? all_architectures : all_cores;
   for (; entry->name != NULL; entry++)
     candidates.safe_push (entry->name);
+
+#ifdef HAVE_LOCAL_CPU_DETECT
+  /* Add also "native" as possible value.  */
+  if (arch)
+    candidates.safe_push ("native");
+#endif
+
   char *s;
   const char *hint = candidates_list_and_hint (str, s, candidates);
   if (hint)
diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
index e3c52f63683..976f9afae54 100644
--- a/gcc/config/aarch64/aarch64.h
+++ b/gcc/config/aarch64/aarch64.h
@@ -1002,6 +1002,7 @@ extern const char *aarch64_rewrite_mcpu (int argc, const char **argv);
 
 #if defined(__aarch64__)
 extern const char *host_detect_local_cpu (int argc, const char **argv);
+#define HAVE_LOCAL_CPU_DETECT
 # define EXTRA_SPEC_FUNCTIONS						\
   { "local_cpu_detect", host_detect_local_cpu },			\
   MCPU_TO_MARCH_SPEC_FUNCTIONS
-- 
2.16.1

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Kyrill Tkachov]

Hi Martin,

On 21/02/18 07:34, Martin Liška wrote:
> Hi.
>
> This is equivalent patch for ARM target.

Thanks for fixing this!

> Ready for trunk?

Have you tested this with a native and a cross-compiler like the aarch64 version?

> Thanks,
> Martin

 From 656a883bc5239439ba80743f15a8df704501ee71 Mon Sep 17 00:00:00 2001
From: marxin<mliska@suse.cz>
Date: Tue, 20 Feb 2018 14:09:22 +0100
Subject: [PATCH 1/3] Add "native" as a valid option value for -march= on arm
  (PR driver/83193).

gcc/ChangeLog:

2018-02-20  Martin Liska<mliska@suse.cz>

	PR driver/83193
	* common/config/arm/arm-common.c (arm_print_hint_for_arch_option):
	Add "native" as a possible value.
	* config/arm/arm.h (HAVE_LOCAL_CPU_DETECT): Define the macro
	when native cpu detection is available.
---
  gcc/common/config/arm/arm-common.c | 6 ++++++
  gcc/config/arm/arm.h               | 1 +
  2 files changed, 7 insertions(+)

diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c
index fc585e0b0ee..50f0bad3e36 100644
--- a/gcc/common/config/arm/arm-common.c
+++ b/gcc/common/config/arm/arm-common.c
@@ -353,6 +353,12 @@ arm_print_hint_for_arch_option (const char *target,
    auto_vec<const char*> candidates;
    for (; list->common.name != NULL; list++)
      candidates.safe_push (list->common.name);
+
+#ifdef HAVE_LOCAL_CPU_DETECT
+  /* Add also "native" as possible value.  */
+  candidates.safe_push ("native");
+#endif
+


On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
to them as well?

Thanks,
Kyrill

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
> Have you tested this with a native and a cross-compiler like the aarch64 version?

No, I don't have a machine. Can you please do that?

Thanks,
Martin

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Kyrill Tkachov]

On 21/02/18 09:53, Martin Liška wrote:
> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>> Have you tested this with a native and a cross-compiler like the aarch64 version?
> No, I don't have a machine. Can you please do that?

Sure, I've bootstrapped and tested it on arm-none-linux-gnueabihf
and an arm-none-eabi cross-compiler. Confirmed that "native" comes up
as a suggestion for a native compiler and not for a cross-compiler.
So the approach looks good. Please address the comment in my previous reply
and this will be ok for trunk.

Thanks,
Kyrill

> Thanks,
> Martin

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
> Have you tested this with a native and a cross-compiler like the aarch64 version?

Yes, you tested that ;) I'm going to install the patch.

Martin

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

On 02/21/2018 03:08 PM, Jakub Jelinek wrote:
> This just adds "native" as possible value for -march, but shouldn't it be
> also for -mtune, i.e. around line 4268?

Thanks for note. There's updated version.

Is it ok now?
Thanks,
Martin

[-- Attachment #2: 0001-Add-native-as-a-valid-option-value-for-march-on-i386.patch --]
[-- Type: text/x-patch, Size: 1543 bytes --]

From 980016be748b8f6a917f497d256c62a054bdece8 Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Tue, 20 Feb 2018 14:21:05 +0100
Subject: [PATCH] Add "native" as a valid option value for -march= on i386 (PR
 driver/83193).

gcc/ChangeLog:

2018-02-20  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* config/i386/i386.c (ix86_option_override_internal):
	Add "native" as a possible value for -march and -mtune.
---
 gcc/config/i386/i386.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
index d54e7301e84..18d9084fd30 100644
--- a/gcc/config/i386/i386.c
+++ b/gcc/config/i386/i386.c
@@ -4193,6 +4193,11 @@ ix86_option_override_internal (bool main_args_p,
 		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
 	  candidates.safe_push (processor_alias_table[i].name);
 
+#ifdef HAVE_LOCAL_CPU_DETECT
+      /* Add also "native" as possible value.  */
+      candidates.safe_push ("native");
+#endif
+
       char *s;
       const char *hint
 	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
@@ -4265,6 +4270,11 @@ ix86_option_override_internal (bool main_args_p,
 	    || ((processor_alias_table[i].flags & PTA_64BIT) != 0))
 	  candidates.safe_push (processor_alias_table[i].name);
 
+#ifdef HAVE_LOCAL_CPU_DETECT
+      /* Add also "native" as possible value.  */
+      candidates.safe_push ("native");
+#endif
+
       char *s;
       const char *hint
 	= candidates_list_and_hint (opts->x_ix86_tune_string, s, candidates);
-- 
2.16.1

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Jakub Jelinek]

On Wed, Feb 21, 2018 at 03:19:22PM +0100, Martin Liška wrote:
> On 02/21/2018 03:08 PM, Jakub Jelinek wrote:
> > This just adds "native" as possible value for -march, but shouldn't it be
> > also for -mtune, i.e. around line 4268?
> 
> Thanks for note. There's updated version.
> 
> Is it ok now?
> Thanks,
> Martin

> >From 980016be748b8f6a917f497d256c62a054bdece8 Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Tue, 20 Feb 2018 14:21:05 +0100
> Subject: [PATCH] Add "native" as a valid option value for -march= on i386 (PR
>  driver/83193).
> 
> gcc/ChangeLog:
> 
> 2018-02-20  Martin Liska  <mliska@suse.cz>
> 
> 	PR driver/83193
> 	* config/i386/i386.c (ix86_option_override_internal):
> 	Add "native" as a possible value for -march and -mtune.

Ok, thanks.

> ---
>  gcc/config/i386/i386.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index d54e7301e84..18d9084fd30 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -4193,6 +4193,11 @@ ix86_option_override_internal (bool main_args_p,
>  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>  	  candidates.safe_push (processor_alias_table[i].name);
>  
> +#ifdef HAVE_LOCAL_CPU_DETECT
> +      /* Add also "native" as possible value.  */
> +      candidates.safe_push ("native");
> +#endif
> +
>        char *s;
>        const char *hint
>  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
> @@ -4265,6 +4270,11 @@ ix86_option_override_internal (bool main_args_p,
>  	    || ((processor_alias_table[i].flags & PTA_64BIT) != 0))
>  	  candidates.safe_push (processor_alias_table[i].name);
>  
> +#ifdef HAVE_LOCAL_CPU_DETECT
> +      /* Add also "native" as possible value.  */
> +      candidates.safe_push ("native");
> +#endif
> +
>        char *s;
>        const char *hint
>  	= candidates_list_and_hint (opts->x_ix86_tune_string, s, candidates);
> -- 
> 2.16.1
> 


	Jakub

Re: [PATCH] Add "native" as a valid option value for -march= on i386 (PR driver/83193).

[Jakub Jelinek]

On Wed, Feb 21, 2018 at 08:33:21AM +0100, Martin Liška wrote:
> >From 8f1783a9017ec06c578fd644e46168ec5763d5ca Mon Sep 17 00:00:00 2001
> From: marxin <mliska@suse.cz>
> Date: Tue, 20 Feb 2018 14:21:05 +0100
> Subject: [PATCH 3/3] Add "native" as a valid option value for -march= on i386
>  (PR driver/83193).
> 
> gcc/ChangeLog:
> 
> 2018-02-20  Martin Liska  <mliska@suse.cz>
> 
> 	PR driver/83193
> 	* config/i386/i386.c (ix86_option_override_internal):
> 	Add "native" as a possible value.
> ---
>  gcc/config/i386/i386.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index d54e7301e84..9f2c5218ae5 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -4193,6 +4193,11 @@ ix86_option_override_internal (bool main_args_p,
>  		|| ((processor_alias_table[i].flags & PTA_64BIT) != 0)))
>  	  candidates.safe_push (processor_alias_table[i].name);
>  
> +#ifdef HAVE_LOCAL_CPU_DETECT
> +      /* Add also "native" as possible value.  */
> +      candidates.safe_push ("native");
> +#endif

This just adds "native" as possible value for -march, but shouldn't it be
also for -mtune, i.e. around line 4268?

> +
>        char *s;
>        const char *hint
>  	= candidates_list_and_hint (opts->x_ix86_arch_string, s, candidates);
> -- 
> 2.16.1
> 


	Jakub

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
> 
> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
> to them as well?

Hi.

Can you please test for me attached follow up patch?
Thanks,
Martin

[-- Attachment #2: 0001-Add-native-as-a-valid-option-value-for-mcpu-mtune-on.patch --]
[-- Type: text/x-patch, Size: 1143 bytes --]

From 3a40e8a873461f9f06a18539cfb7c366dd6efafb Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Wed, 21 Feb 2018 15:38:32 +0100
Subject: [PATCH] Add "native" as a valid option value for -mcpu/-mtune= on arm
 (PR driver/83193).

gcc/ChangeLog:

2018-02-21  Martin Liska  <mliska@suse.cz>

	PR driver/83193
	* common/config/arm/arm-common.c (arm_print_hint_for_cpu_option):
	Add "native" as a possible value.
---
 gcc/common/config/arm/arm-common.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gcc/common/config/arm/arm-common.c b/gcc/common/config/arm/arm-common.c
index 50f0bad3e36..a404d4b1562 100644
--- a/gcc/common/config/arm/arm-common.c
+++ b/gcc/common/config/arm/arm-common.c
@@ -309,6 +309,12 @@ arm_print_hint_for_cpu_option (const char *target,
   auto_vec<const char*> candidates;
   for (; list->common.name != NULL; list++)
     candidates.safe_push (list->common.name);
+
+#ifdef HAVE_LOCAL_CPU_DETECT
+  /* Add also "native" as possible value.  */
+  candidates.safe_push ("native");
+#endif
+
   char *s;
   const char *hint = candidates_list_and_hint (target, s, candidates);
   if (hint)
-- 
2.16.1

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Kyrill Tkachov]

Hi Martin,

On 22/02/18 08:51, Martin Liška wrote:
> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
>> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
>> to them as well?
> Hi.
>
> Can you please test for me attached follow up patch?

I've bootstrapped and tested this patch on a native and a cross compiler and confirmed
the help string for -mcpu behaves as intended.

This patch is ok for trunk.
Thanks,
Kyrill

> Thanks,
> Martin

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

On 02/22/2018 11:59 AM, Kyrill Tkachov wrote:
> Hi Martin,
> 
> On 22/02/18 08:51, Martin Liška wrote:
>> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>>> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
>>> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
>>> to them as well?
>> Hi.
>>
>> Can you please test for me attached follow up patch?
> 
> I've bootstrapped and tested this patch on a native and a cross compiler and confirmed
> the help string for -mcpu behaves as intended.
> 
> This patch is ok for trunk.
> Thanks,
> Kyrill

Thanks for review. May I please ask you for taking look at:
2b) point in:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83193#c6

We should fix it (if possible) for GCC 8 as it's regression.

Thanks,
Martin

> 
>> Thanks,
>> Martin
> 

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

PING^1

On 02/22/2018 01:15 PM, Martin Liška wrote:
> On 02/22/2018 11:59 AM, Kyrill Tkachov wrote:
>> Hi Martin,
>>
>> On 22/02/18 08:51, Martin Liška wrote:
>>> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>>>> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
>>>> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
>>>> to them as well?
>>> Hi.
>>>
>>> Can you please test for me attached follow up patch?
>>
>> I've bootstrapped and tested this patch on a native and a cross compiler and confirmed
>> the help string for -mcpu behaves as intended.
>>
>> This patch is ok for trunk.
>> Thanks,
>> Kyrill
> 
> Thanks for review. May I please ask you for taking look at:
> 2b) point in:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83193#c6
> 
> We should fix it (if possible) for GCC 8 as it's regression.
> 
> Thanks,
> Martin
> 
>>
>>> Thanks,
>>> Martin
>>
> 

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Kyrill Tkachov]

On 22/02/18 12:15, Martin Liška wrote:
> On 02/22/2018 11:59 AM, Kyrill Tkachov wrote:
>> Hi Martin,
>>
>> On 22/02/18 08:51, Martin Liška wrote:
>>> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>>>> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
>>>> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
>>>> to them as well?
>>> Hi.
>>>
>>> Can you please test for me attached follow up patch?
>> I've bootstrapped and tested this patch on a native and a cross compiler and confirmed
>> the help string for -mcpu behaves as intended.
>>
>> This patch is ok for trunk.
>> Thanks,
>> Kyrill
> Thanks for review. May I please ask you for taking look at:
> 2b) point in:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83193#c6
>
> We should fix it (if possible) for GCC 8 as it's regression.

Thanks for the reminders Martin.
I've committed a patch to fix it with r258389.

Kyrill

> Thanks,
> Martin
>
>>> Thanks,
>>> Martin

Re: Add "native" as a valid option value for -march= on arm (PR driver/83193).

[Martin Liška]

On 03/09/2018 04:43 PM, Kyrill Tkachov wrote:
> 
> On 22/02/18 12:15, Martin Liška wrote:
>> On 02/22/2018 11:59 AM, Kyrill Tkachov wrote:
>>> Hi Martin,
>>>
>>> On 22/02/18 08:51, Martin Liška wrote:
>>>> On 02/21/2018 10:23 AM, Kyrill Tkachov wrote:
>>>>> On arm we also support "native" as a value for -mcpu and -mtune. These are both handled by
>>>>> the arm_print_hint_for_cpu_option function in the same file. Can you please add this snippet
>>>>> to them as well?
>>>> Hi.
>>>>
>>>> Can you please test for me attached follow up patch?
>>> I've bootstrapped and tested this patch on a native and a cross compiler and confirmed
>>> the help string for -mcpu behaves as intended.
>>>
>>> This patch is ok for trunk.
>>> Thanks,
>>> Kyrill
>> Thanks for review. May I please ask you for taking look at:
>> 2b) point in:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83193#c6
>>
>> We should fix it (if possible) for GCC 8 as it's regression.
> 
> Thanks for the reminders Martin.
> I've committed a patch to fix it with r258389.

I thank you for taking care of the ARM-specific issue. Let me adjust milestone
of the PR to 9. The rest of issue seen can't be fixed now.

Martin

> 
> Kyrill
> 
>> Thanks,
>> Martin
>>
>>>> Thanks,
>>>> Martin
>