* [Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325
@ 2018-02-23 18:08 Paul Richard Thomas
2018-02-23 18:47 ` Steve Kargl
0 siblings, 1 reply; 2+ messages in thread
From: Paul Richard Thomas @ 2018-02-23 18:08 UTC (permalink / raw)
To: fortran, gcc-patches
Hi All,
The original bug is fixed as 'obvious' in revision 257938. This is
indeed a regression.
The bug in comments 2 and 7 is fixed in revision 257934. This,
however, is not a regression. The summary will be changed accordingly.
The 'obvious' tag comes about because both bugs have a common origin:
referencing the components of ns->proc_name without testing to see if
it is there.
Should I close this or should I apply the second part to 7-branch?
Cheers
Paul
>>>>>revision 257938:
2018-02-23 Paul Thomas <pault@gcc.gnu.org>
PR fortran/83149
* trans-types.c (gfc_sym_type): Test sym->ns->proc_name before
accessing its components.
2018-02-23 Paul Thomas <pault@gcc.gnu.org>
PR fortran/83149
* gfortran.dg/pr83149_b.f90: New test.
* gfortran.dg/pr83149_a.f90: Additional source for previous.
>>>>>revision 257934:
2018-02-23 Paul Thomas <pault@gcc.gnu.org>
PR fortran/83149
* trans-decl.c (gfc_finish_var_decl): Test sym->ns->proc_name
before accessing its components.
2018-02-23 Paul Thomas <pault@gcc.gnu.org>
PR fortran/83149
* gfortran.dg/pr83149_1.f90: New test.
* gfortran.dg/pr83149.f90: Additional source for previous.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325
2018-02-23 18:08 [Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325 Paul Richard Thomas
@ 2018-02-23 18:47 ` Steve Kargl
0 siblings, 0 replies; 2+ messages in thread
From: Steve Kargl @ 2018-02-23 18:47 UTC (permalink / raw)
To: Paul Richard Thomas; +Cc: fortran, gcc-patches
On Fri, Feb 23, 2018 at 06:08:23PM +0000, Paul Richard Thomas wrote:
>
> The original bug is fixed as 'obvious' in revision 257938. This is
> indeed a regression.
>
> The bug in comments 2 and 7 is fixed in revision 257934. This,
> however, is not a regression. The summary will be changed accordingly.
>
> The 'obvious' tag comes about because both bugs have a common origin:
> referencing the components of ns->proc_name without testing to see if
> it is there.
>
> Should I close this or should I apply the second part to 7-branch?
>
If the back port is a trivial effort, then I would back port
to try to keep 6, 7, and trunk somewhat in sync. This is
simply to aid in maintenance against future bug reports. I'll
leave the "trivial" decision up to you.
--
Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 18:08 [Patch, fortran] PR83149 [8 Regression] ICE on SELECT CASE: crash_signal in toplev.c:325 Paul Richard Thomas
2018-02-23 18:47 ` Steve Kargl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).