From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Piotr Trojanek <trojanek@adacore.com>
Subject: [Ada] Use function and not procedure UI_Image in pretty-printing
Date: Tue, 4 May 2021 05:52:23 -0400 [thread overview]
Message-ID: <20210504095223.GA90568@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
Code cleanup; semantics is unaffected. The code for pretty-printing
integer, real and string literals now looks the same.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* pprint.adb (Expr_Name): Simplify with functional variant of
UI_Image.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 454 bytes --]
diff --git a/gcc/ada/pprint.adb b/gcc/ada/pprint.adb
--- a/gcc/ada/pprint.adb
+++ b/gcc/ada/pprint.adb
@@ -226,8 +226,7 @@ package body Pprint is
end;
when N_Integer_Literal =>
- UI_Image (Intval (Expr));
- return UI_Image_Buffer (1 .. UI_Image_Length);
+ return UI_Image (Intval (Expr));
when N_Real_Literal =>
return Real_Image (Realval (Expr));
reply other threads:[~2021-05-04 9:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210504095223.GA90568@adacore.com \
--to=derodat@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=trojanek@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).