[Ada] Variable-sized node types -- cleanup

[Ada] Variable-sized node types -- cleanup

[Pierre-Marie de Rodat]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

Fix incorrect comments. Clean up ???? marks. Rename Set_Ekind to be
Mutate_Ekind to match Mutate_Nkind.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* atree.ads, atree.adb, gen_il-gen.ads: Fix comments and clean
	up ???  marks.  Rename Set_Ekind to be Mutate_Ekind.
	* einfo.ads, sinfo.ads: Likewise.  Change "definitive
	definition" to "official definition", because the former sounds
	redundant.  Rename Set_Ekind to be Mutate_Ekind.
	* checks.adb, contracts.adb, cstand.adb, exp_aggr.adb,
	exp_attr.adb, exp_ch11.adb, exp_ch3.adb, exp_ch5.adb,
	exp_ch6.adb, exp_ch7.adb, exp_ch9.adb, exp_disp.adb,
	exp_dist.adb, exp_imgv.adb, exp_intr.adb, exp_prag.adb,
	exp_unst.adb, exp_util.adb, gen_il-gen.adb, inline.adb,
	lib-writ.adb, lib-xref-spark_specific.adb, sem_aggr.adb,
	sem_ch10.adb, sem_ch11.adb, sem_ch12.adb, sem_ch13.adb,
	sem_ch3.adb, sem_ch5.adb, sem_ch6.adb, sem_ch7.adb, sem_ch8.adb,
	sem_ch9.adb, sem_dist.adb, sem_elab.adb, sem_prag.adb,
	sem_util.adb: Rename Set_Ekind to be Mutate_Ekind.

[-- Attachment #2: patch.diff.gz --]
[-- Type: application/gzip, Size: 32391 bytes --]

[Ada] Variable-sized node types -- cleanup

[Pierre-Marie de Rodat]

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

This commit does various cleanups related to the previous change for
variable-sized node types:

* Clean up ??? comments. Remove redundant ones, and ones that are not
  worth fixing.

* Improve comments.

* Add support for getter-specific and setter-specific preconditions.

* Detect the error of putting a field in the wrong subrange (Node_Field
  vs. Entity_Field).

* Add Named_Access_Kind.

* Clean up Nmake. It is no longer necessary to mimic the old version for
  testing purposes.

* Remove redundant assertions from Sinfo.CN.

Tested on x86_64-pc-linux-gnu, committed on trunk

gcc/ada/

	* atree.ads, einfo-utils.ads, einfo-utils.adb, fe.h, gen_il.adb,
	gen_il.ads, gen_il-gen-gen_entities.adb,
	gen_il-gen-gen_nodes.adb, sem_ch12.adb, sem_ch3.adb,
	sem_util.adb, sinfo-utils.ads, treepr.adb, types.ads: Clean up
	??? comments and other comments.
	* atree.adb: Clean up ??? comments and other comments.
	(Validate_Node): Fix bug: "Off_0 (N) < Off_L (N)"
	should be "Off_0 (N) <= Off_L (N)".
	* gen_il-gen.adb, gen_il-gen.ads: Clean up ???
	comments and other comments.  Add support for getter-specific
	and setter-specific preconditions.  Detect the error of putting
	a field in the wrong subrange.  Misc cleanup.
	(Node_Field vs. Entity_Field): Clean up Nmake.  Improve
	comments.
	* gen_il-utils.ads: Misc cleanup. Move...
	* gen_il-internals.ads: ... here.
	* gen_il-utils.adb: Misc cleanup. Move...
	* gen_il-internals.adb: ... here.
	* gen_il-fields.ads: Move Was_Default_Init_Box_Association,
	which was in the wrong subrange.  Add comments.  Misc cleanup.
	* gen_il-types.ads: Add Named_Access_Kind.
	* sinfo-cn.adb: Clean up ??? comments and other comments.
	Remove redundant assertions.
	* einfo.ads, sinfo.ads: Clean up ??? comments and other
	comments.  Remove all the comments indicating field offsets.
	These are obsolete now that Gen_IL computes the offsets
	automatically.

[-- Attachment #2: patch.diff.gz --]
[-- Type: application/gzip, Size: 152358 bytes --]