* [pushed] c++: reject class lvalues in 'rvalue'
@ 2021-05-07 16:10 Jason Merrill
0 siblings, 0 replies; only message in thread
From: Jason Merrill @ 2021-05-07 16:10 UTC (permalink / raw)
To: gcc-patches
Wrapping a class lvalue in NON_LVALUE_EXPR is not sufficient to make it a
usable prvalue; callers must use force_rvalue instead.
Tested x86_64-pc-linux-gnu, applying to trunk.
gcc/cp/ChangeLog:
* tree.c (rvalue): Assert expr is not a class lvalue.
---
gcc/cp/tree.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 4ccd7a314f5..7f148b4b158 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -940,7 +940,12 @@ rvalue (tree expr)
/* We need to do this for rvalue refs as well to get the right answer
from decltype; see c++/36628. */
if (!processing_template_decl && glvalue_p (expr))
- expr = build1 (NON_LVALUE_EXPR, type, expr);
+ {
+ /* But don't use this function for class lvalues; use move (to treat an
+ lvalue as an xvalue) or force_rvalue (to make a prvalue copy). */
+ gcc_checking_assert (!CLASS_TYPE_P (type));
+ expr = build1 (NON_LVALUE_EXPR, type, expr);
+ }
else if (type != TREE_TYPE (expr))
expr = build_nop (type, expr);
base-commit: fc178519771db508c03611cff4a1466cf67fce1d
--
2.27.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-07 16:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 16:10 [pushed] c++: reject class lvalues in 'rvalue' Jason Merrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).