From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH] rs6000/test: Update some cases with -mdejagnu-tune
Date: Thu, 21 Jul 2022 13:48:06 -0500 [thread overview]
Message-ID: <20220721184806.GK25951@gate.crashing.org> (raw)
In-Reply-To: <4847b51d-dde2-916b-27aa-8e63518d66d2@linux.ibm.com>
Hi!
On Wed, Jul 20, 2022 at 05:31:11PM +0800, Kewen.Lin wrote:
> As PR106345 shows, some test cases should be updated with
> -mdejagnu-tune, since their test points are sensitive to
> rs6000_tune, such as: group_ending_nop, loop align (ic),
> float conversion cost etc.
It does not make sense to require -mdejagnu-tune= if -mdejagnu-cpu= is
already given? What is the failure case?
> This patch is to replace -mdejagnu-cpu with -mdejagnu-tune
> or append -mdejagnu-tune (keep the original -mdejagnu-cpu
> when it's required) accordingly.
It is *always* required. Testcases with -mtune= but unspecified -mcpu=
make no sense.
> --- a/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c
> +++ b/gcc/testsuite/gcc.target/powerpc/compress-float-ppc-pic.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile { target powerpc_fprs } } */
> -/* { dg-options "-O2 -fpic -mdejagnu-cpu=power5" } */
> +/* { dg-options "-O2 -fpic -mdejagnu-cpu=power5 -mdejagnu-tune=power5" } */
> /* { dg-require-effective-target fpic } */
This should only make a difference if you have -mtune= in your
RUNTEST_FLAGS, and you shouldn't do silly things like that. I suspect
you see it in other cases, and those are actual bugs then, that need
actual fixing instead of sweeping under the carper.
The testcase suggests this is with a compiler configured with
--with-cpu= --with-tune=, which should just work, and -mcpu= should
override both of those!
Segher
next prev parent reply other threads:[~2022-07-21 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 9:31 Kewen.Lin
2022-07-21 18:48 ` Segher Boessenkool [this message]
2022-07-22 2:22 ` Kewen.Lin
2022-07-22 18:17 ` Segher Boessenkool
2022-07-22 18:53 ` Peter Bergner
2022-07-22 19:28 ` Peter Bergner
2022-07-25 6:09 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721184806.GK25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).