* [PATCH] tree-optimization/73550 - apply MAX_NUM_CHAINS consistently
@ 2022-08-30 13:37 Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-08-30 13:37 UTC (permalink / raw)
To: gcc-patches
The MAX_NUM_CHAINS is applied once with <= and once with < which
results in the chains not limited but analyis dropped completely.
That's one issue in the PR.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR tree-optimization/73550
* gimple-predicate-analysis.cc (predicate::init_from_control_deps):
Do not apply MAX_NUM_CHAINS again.
---
gcc/gimple-predicate-analysis.cc | 7 -------
1 file changed, 7 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc
index f9ae8910a26..6f30d729df2 100644
--- a/gcc/gimple-predicate-analysis.cc
+++ b/gcc/gimple-predicate-analysis.cc
@@ -1674,13 +1674,6 @@ predicate::init_from_control_deps (const vec<edge> *dep_chains,
if (num_chains == 0)
return;
- if (num_chains >= MAX_NUM_CHAINS)
- {
- if (dump_file)
- fprintf (dump_file, "MAX_NUM_CHAINS exceeded: %u\n", num_chains);
- return;
- }
-
/* Convert the control dependency chain into a set of predicates. */
m_preds.reserve (num_chains);
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] tree-optimization/73550 - apply MAX_NUM_CHAINS consistently
@ 2022-08-30 13:37 Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-08-30 13:37 UTC (permalink / raw)
To: gcc-patches
The MAX_NUM_CHAINS is applied once with <= and once with < which
results in the chains not limited but analyis dropped completely.
That's one issue in the PR.
Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
PR tree-optimization/73550
* gimple-predicate-analysis.cc (predicate::init_from_control_deps):
Do not apply MAX_NUM_CHAINS again.
---
gcc/gimple-predicate-analysis.cc | 7 -------
1 file changed, 7 deletions(-)
diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc
index f9ae8910a26..6f30d729df2 100644
--- a/gcc/gimple-predicate-analysis.cc
+++ b/gcc/gimple-predicate-analysis.cc
@@ -1674,13 +1674,6 @@ predicate::init_from_control_deps (const vec<edge> *dep_chains,
if (num_chains == 0)
return;
- if (num_chains >= MAX_NUM_CHAINS)
- {
- if (dump_file)
- fprintf (dump_file, "MAX_NUM_CHAINS exceeded: %u\n", num_chains);
- return;
- }
-
/* Convert the control dependency chain into a set of predicates. */
m_preds.reserve (num_chains);
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-30 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-30 13:37 [PATCH] tree-optimization/73550 - apply MAX_NUM_CHAINS consistently Richard Biener
-- strict thread matches above, loose matches on Subject: below --
2022-08-30 13:37 Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).