From: Aldy Hernandez <aldyh@redhat.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Cc: Andrew MacLeod <amacleod@redhat.com>, Aldy Hernandez <aldyh@redhat.com>
Subject: [COMMITTED] Drop -0.0 in frange::set() for !HONOR_SIGNED_ZEROS.
Date: Fri, 14 Oct 2022 16:26:50 +0200 [thread overview]
Message-ID: <20221014142652.671475-1-aldyh@redhat.com> (raw)
Similar to what we do for NANs when !HONOR_NANS and Inf when
flag_finite_math_only, we can remove -0.0 from the range at creation
time.
We were kinda sorta doing this because there is a bug in
real_isdenormal that is causing flush_denormals_to_zero to saturate
[x, -0.0] to [x, +0.0] when !HONOR_SIGNED_ZEROS. Fixing this bug
(upcoming), causes us to leave -0.0 in places where we aren't
expecting it (the intersection code).
gcc/ChangeLog:
* value-range.cc (frange::set): Drop -0.0 for !HONOR_SIGNED_ZEROS.
---
gcc/value-range.cc | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index 26a2b782e2c..86550f158b8 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -324,6 +324,14 @@ frange::set (tree type,
m_neg_nan = false;
}
+ if (!HONOR_SIGNED_ZEROS (m_type))
+ {
+ if (real_iszero (&m_min, 1))
+ m_min.sign = 0;
+ if (real_iszero (&m_max, 1))
+ m_max.sign = 0;
+ }
+
// For -ffinite-math-only we can drop ranges outside the
// representable numbers to min/max for the type.
if (flag_finite_math_only)
--
2.37.3
next reply other threads:[~2022-10-14 14:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 14:26 Aldy Hernandez [this message]
2022-10-14 14:26 ` [COMMITTED] Normalize ranges over the range for both bounds when -ffinite-math-only Aldy Hernandez
2022-10-14 14:26 ` [COMMITTED] Replace CFN_BUILTIN_SIGNBIT* cases with CASE_FLT_FN Aldy Hernandez
2022-10-14 14:32 ` [COMMITTED] Drop -0.0 in frange::set() for !HONOR_SIGNED_ZEROS Jakub Jelinek
2022-10-14 14:53 ` Aldy Hernandez
2022-10-14 15:00 ` Jakub Jelinek
2022-10-14 15:06 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014142652.671475-1-aldyh@redhat.com \
--to=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).