* **[COMMITTED] Update selftest such that [-Inf, +Inf] is always VARYING for -ffinite-math-only.**
**@ 2022-10-22 14:25 Aldy Hernandez**
0 siblings, 0 replies; only message in thread
From: Aldy Hernandez @ 2022-10-22 14:25 UTC (permalink / raw)
To: GCC patches; **+Cc:** Jeff Law, Andrew MacLeod, Aldy Hernandez
[-Inf, +Inf] +-NAN gets normalized as VARYING. There is a test that
drops the NAN possibility, and tests that the range is no longer
VARYING but [-Inf, +Inf]. However, for -ffinite-math-only targets
(Vax, RX, etc) the range would still be VARYING because the VARYING
range never had a NAN to begin with. This fixes the test.
I have a precommit hook that does self-tests with
-fno-finite-math-only, -ffinite-math-only, and -ffast-math as a sanity
check, but my precommit hook last week was disabled because there was
a tree-ssa.exp in mainline failing which was throwing off my scripts.
My apologies.
gcc/ChangeLog:
* value-range.cc (range_tests_floats): Predicate [-Inf, +Inf] test
with !flag_finite_math_only.
---
gcc/value-range.cc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index bcda4987307..d779e9819e2 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -3960,8 +3960,11 @@ range_tests_floats ()
if (r0.maybe_isnan ())
ASSERT_TRUE (r0.varying_p ());
// ...unless it has some special property...
- r0.clear_nan ();
- ASSERT_FALSE (r0.varying_p ());
+ if (!flag_finite_math_only)
+ {
+ r0.clear_nan ();
+ ASSERT_FALSE (r0.varying_p ());
+ }
// For most architectures, where float and double are different
// sizes, having the same endpoints does not necessarily mean the
--
2.37.3
^ permalink raw reply [**flat**|nested] only message in thread

only message in thread, other threads:[~2022-10-22 14:25 UTC | newest]
**Thread overview:** (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-22 14:25 [COMMITTED] Update selftest such that [-Inf, +Inf] is always VARYING for -ffinite-math-only Aldy Hernandez

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).