* [PATCH] tree-optimization/107686 - fix bitfield ref through vec_unpack optimization
@ 2022-11-16 15:34 Richard Biener
0 siblings, 0 replies; only message in thread
From: Richard Biener @ 2022-11-16 15:34 UTC (permalink / raw)
To: gcc-patches
The following propely restricts the bitfield access to integral types
when we look through VEC_UNPACK with the intent to emit a widening
conversion.
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress.
PR tree-optimization/107686
* tree-ssa-forwprop.cc (optimize_vector_load): Restrict
VEC_UNPACK support to integral typed bitfield refs.
* gcc.dg/pr107686.c: New testcase.
---
gcc/testsuite/gcc.dg/pr107686.c | 16 ++++++++++++++++
gcc/tree-ssa-forwprop.cc | 6 +++++-
2 files changed, 21 insertions(+), 1 deletion(-)
create mode 100644 gcc/testsuite/gcc.dg/pr107686.c
diff --git a/gcc/testsuite/gcc.dg/pr107686.c b/gcc/testsuite/gcc.dg/pr107686.c
new file mode 100644
index 00000000000..2378103c555
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr107686.c
@@ -0,0 +1,16 @@
+/* { dg-do compile { target { dfp && longlong64 } } } */
+/* { dg-options "-O" } */
+/* { dg-additional-options "-mavx2" { target x86_64-*-* i?86-*-* } } */
+
+typedef _Decimal64 __attribute__((__vector_size__ (64))) D;
+typedef __INT32_TYPE__ __attribute__((__vector_size__ (32))) U;
+typedef __INT64_TYPE__ __attribute__((__vector_size__ (64))) V;
+
+U u;
+D d;
+
+void
+foo (void)
+{
+ d = d < (D) __builtin_convertvector (u, V);
+}
diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc
index 7c7942600ef..429f77f199c 100644
--- a/gcc/tree-ssa-forwprop.cc
+++ b/gcc/tree-ssa-forwprop.cc
@@ -3162,7 +3162,11 @@ optimize_vector_load (gimple_stmt_iterator *gsi)
&& (def == lhs
|| (known_eq (bit_field_size (use_rhs), def_eltsize)
&& constant_multiple_p (bit_field_offset (use_rhs),
- def_eltsize))))
+ def_eltsize)
+ /* We can simulate the VEC_UNPACK_{HI,LO}_EXPR
+ via a NOP_EXPR only for integral types.
+ ??? Support VEC_UNPACK_FLOAT_{HI,LO}_EXPR. */
+ && INTEGRAL_TYPE_P (TREE_TYPE (use_rhs)))))
{
bf_stmts.safe_push (use_stmt);
continue;
--
2.35.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-16 15:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 15:34 [PATCH] tree-optimization/107686 - fix bitfield ref through vec_unpack optimization Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).