* [committed] analyzer: fix ICE on 'bind' with non-pointer arg [P107783]
@ 2022-11-22 0:14 David Malcolm
0 siblings, 0 replies; only message in thread
From: David Malcolm @ 2022-11-22 0:14 UTC (permalink / raw)
To: gcc-patches; +Cc: David Malcolm
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
Pushed to trunk as r13-4220-g12a4785c9120be.
gcc/analyzer/ChangeLog:
PR analyzer/107783
* region-model-impl-calls.cc (kf_accept::matches_call_types_p):
Require that args 1 and 2 be pointers.
(kf_bind::matches_call_types_p): Require that arg 1 be a pointer.
* region-model.h (call_details::arg_is_pointer_p): New
gcc/testsuite/ChangeLog:
PR analyzer/107783
* gcc.dg/analyzer/fd-bind-pr107783.c: New test.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---
gcc/analyzer/region-model-impl-calls.cc | 6 ++++--
gcc/analyzer/region-model.h | 4 ++++
gcc/testsuite/gcc.dg/analyzer/fd-bind-pr107783.c | 5 +++++
3 files changed, 13 insertions(+), 2 deletions(-)
create mode 100644 gcc/testsuite/gcc.dg/analyzer/fd-bind-pr107783.c
diff --git a/gcc/analyzer/region-model-impl-calls.cc b/gcc/analyzer/region-model-impl-calls.cc
index a71eb3de98f..8a44c97eec9 100644
--- a/gcc/analyzer/region-model-impl-calls.cc
+++ b/gcc/analyzer/region-model-impl-calls.cc
@@ -595,7 +595,9 @@ class kf_accept : public known_function
bool matches_call_types_p (const call_details &cd) const final override
{
- return cd.num_args () == 3;
+ return (cd.num_args () == 3
+ && cd.arg_is_pointer_p (1)
+ && cd.arg_is_pointer_p (2));
}
void impl_call_post (const call_details &cd) const final override
@@ -633,7 +635,7 @@ public:
bool matches_call_types_p (const call_details &cd) const final override
{
- return cd.num_args () == 3;
+ return (cd.num_args () == 3 && cd.arg_is_pointer_p (1));
}
void impl_call_post (const call_details &cd) const final override
diff --git a/gcc/analyzer/region-model.h b/gcc/analyzer/region-model.h
index c828d739482..244780eb4f4 100644
--- a/gcc/analyzer/region-model.h
+++ b/gcc/analyzer/region-model.h
@@ -256,6 +256,10 @@ public:
bool maybe_set_lhs (const svalue *result) const;
unsigned num_args () const;
+ bool arg_is_pointer_p (unsigned idx) const
+ {
+ return POINTER_TYPE_P (get_arg_type (idx));
+ }
const gcall *get_call_stmt () const { return m_call; }
location_t get_location () const;
diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-bind-pr107783.c b/gcc/testsuite/gcc.dg/analyzer/fd-bind-pr107783.c
new file mode 100644
index 00000000000..36304179b43
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/analyzer/fd-bind-pr107783.c
@@ -0,0 +1,5 @@
+int
+foo (void)
+{
+ return bind (0, 0, 0); /* { dg-warning "implicit declaration of function 'bind'" } */
+}
--
2.26.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-22 0:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 0:14 [committed] analyzer: fix ICE on 'bind' with non-pointer arg [P107783] David Malcolm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).