* [PATCH] libiberty: Handle Windows nul device in unlink-if-ordinary.c [PR108276]
@ 2023-01-04 3:09 Himal
2023-01-06 8:23 ` [PATCH] Handle Windows nul device in unlink-if-ordinary.c anothername27-unity
2023-01-06 8:31 ` anothername27-unity
0 siblings, 2 replies; 6+ messages in thread
From: Himal @ 2023-01-04 3:09 UTC (permalink / raw)
To: gcc-patches
libiberty/ChangeLog:
* unlink-if-ordinary.c (unlink_if_ordinary):
Handle Windows nul device
---
libiberty/unlink-if-ordinary.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/libiberty/unlink-if-ordinary.c b/libiberty/unlink-if-ordinary.c
index 84328b216..ae9090e54 100644
--- a/libiberty/unlink-if-ordinary.c
+++ b/libiberty/unlink-if-ordinary.c
@@ -62,11 +62,18 @@ was made to unlink the file because it is special.
int
unlink_if_ordinary (const char *name)
{
+/* MS-Windows 'stat' function (and in turn, S_ISREG)
+ reports the null device as a regular file. */
+#ifdef _WIN32
+ if (stricmp (name, "nul") == 0)
+ return 1;
+#else
struct stat st;
if (lstat (name, &st) == 0
&& (S_ISREG (st.st_mode) || S_ISLNK (st.st_mode)))
return unlink (name);
+#endif
return 1;
}
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] Handle Windows nul device in unlink-if-ordinary.c
2023-01-04 3:09 [PATCH] libiberty: Handle Windows nul device in unlink-if-ordinary.c [PR108276] Himal
@ 2023-01-06 8:23 ` anothername27-unity
2023-01-06 8:31 ` anothername27-unity
1 sibling, 0 replies; 6+ messages in thread
From: anothername27-unity @ 2023-01-06 8:23 UTC (permalink / raw)
To: gcc-patches, himalr
From: Himal <himalr@proton.me>
Hi,
This might be a better fix.
Thanks.
---
libiberty/unlink-if-ordinary.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libiberty/unlink-if-ordinary.c b/libiberty/unlink-if-ordinary.c
index 84328b216..e765ac8b1 100644
--- a/libiberty/unlink-if-ordinary.c
+++ b/libiberty/unlink-if-ordinary.c
@@ -62,6 +62,12 @@ was made to unlink the file because it is special.
int
unlink_if_ordinary (const char *name)
{
+/* MS-Windows 'stat' function (and in turn, S_ISREG)
+ reports the null device as a regular file. */
+#ifdef _WIN32
+ if (stricmp (name, "nul") == 0)
+ return 1;
+#endif
struct stat st;
if (lstat (name, &st) == 0
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] Handle Windows nul device in unlink-if-ordinary.c
2023-01-04 3:09 [PATCH] libiberty: Handle Windows nul device in unlink-if-ordinary.c [PR108276] Himal
2023-01-06 8:23 ` [PATCH] Handle Windows nul device in unlink-if-ordinary.c anothername27-unity
@ 2023-01-06 8:31 ` anothername27-unity
2023-03-11 20:18 ` Jeff Law
1 sibling, 1 reply; 6+ messages in thread
From: anothername27-unity @ 2023-01-06 8:31 UTC (permalink / raw)
To: gcc-patches; +Cc: Himal
From: Himal <himalr@proton.me>
Hi,
This might be a better fix.
Regards.
PS. I had to use a different email.
---
libiberty/unlink-if-ordinary.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libiberty/unlink-if-ordinary.c b/libiberty/unlink-if-ordinary.c
index 84328b216..e765ac8b1 100644
--- a/libiberty/unlink-if-ordinary.c
+++ b/libiberty/unlink-if-ordinary.c
@@ -62,6 +62,12 @@ was made to unlink the file because it is special.
int
unlink_if_ordinary (const char *name)
{
+/* MS-Windows 'stat' function (and in turn, S_ISREG)
+ reports the null device as a regular file. */
+#ifdef _WIN32
+ if (stricmp (name, "nul") == 0)
+ return 1;
+#endif
struct stat st;
if (lstat (name, &st) == 0
--
2.39.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Handle Windows nul device in unlink-if-ordinary.c
2023-01-06 8:31 ` anothername27-unity
@ 2023-03-11 20:18 ` Jeff Law
2023-03-13 5:15 ` Himal
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Law @ 2023-03-11 20:18 UTC (permalink / raw)
To: anothername27-unity, gcc-patches; +Cc: Himal
On 1/6/23 01:31, anothername27-unity--- via Gcc-patches wrote:
> From: Himal <himalr@proton.me>
>
> Hi,
>
> This might be a better fix.
>
> Regards.
>
> PS. I had to use a different email.
>
> ---
> libiberty/unlink-if-ordinary.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libiberty/unlink-if-ordinary.c b/libiberty/unlink-if-ordinary.c
> index 84328b216..e765ac8b1 100644
> --- a/libiberty/unlink-if-ordinary.c
> +++ b/libiberty/unlink-if-ordinary.c
> @@ -62,6 +62,12 @@ was made to unlink the file because it is special.
> int
> unlink_if_ordinary (const char *name)
> {
> +/* MS-Windows 'stat' function (and in turn, S_ISREG)
> + reports the null device as a regular file. */
> +#ifdef _WIN32
> + if (stricmp (name, "nul") == 0)
> + return 1;
> +#endif
Umm, wouldn't this return true for a real file called nul in the current
directory? ie, don't you need to distinguish between the nul device and
a file named nul based on the full path?
And not being a windows person, I'd really like to see some
documentation which indicates that stat on the null device will indicate
its a regular file. Alternately if one of the windows experts here can
chime in, it'd be appreciated.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Handle Windows nul device in unlink-if-ordinary.c
2023-03-11 20:18 ` Jeff Law
@ 2023-03-13 5:15 ` Himal
2023-04-29 18:10 ` Jeff Law
0 siblings, 1 reply; 6+ messages in thread
From: Himal @ 2023-03-13 5:15 UTC (permalink / raw)
To: Jeff Law, gcc-patches
On 3/12/2023 1:48 AM, Jeff Law wrote:
>
>
> On 1/6/23 01:31, anothername27-unity--- via Gcc-patches wrote:
>> From: Himal <himalr@proton.me>
>>
>> Hi,
>>
>> This might be a better fix.
>>
>> Regards.
>>
>> PS. I had to use a different email.
>>
>> ---
>> libiberty/unlink-if-ordinary.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/libiberty/unlink-if-ordinary.c
>> b/libiberty/unlink-if-ordinary.c
>> index 84328b216..e765ac8b1 100644
>> --- a/libiberty/unlink-if-ordinary.c
>> +++ b/libiberty/unlink-if-ordinary.c
>> @@ -62,6 +62,12 @@ was made to unlink the file because it is special.
>> int
>> unlink_if_ordinary (const char *name)
>> {
>> +/* MS-Windows 'stat' function (and in turn, S_ISREG)
>> + reports the null device as a regular file. */
>> +#ifdef _WIN32
>> + if (stricmp (name, "nul") == 0)
>> + return 1;
>> +#endif
Hi Jeff, Thanks for the response.
> Umm, wouldn't this return true for a real file called nul in the
> current directory? ie, don't you need to distinguish between the nul
> device and a file named nul based on the full path?
I don't think that we can create a file called nul under Windows.
> And not being a windows person, I'd really like to see some
> documentation which indicates that stat on the null device will
> indicate its a regular file. Alternately if one of the windows
> experts here can chime in, it'd be appreciated.
> jeff
I found these patches that might indicate the same thing.
https://src.fedoraproject.org/rpms/binutils/blob/0b119dd9d51a3763db7d6fea1b51a03494cb96d8/f/binutils-CVE-2021-20197.patch#_121-135
https://github.com/msys2/MINGW-packages/pull/10541/files
I would like to see some input from a Windows developer as well.
BTW, This doesn't affecting anything. I stumbled upon this while
debugging another
[bug](https://sourceware.org/bugzilla/show_bug.cgi?id=29947). I noticed
it's calling unlink function for the nul device as well, but it wasn't
throwing any errors or anything like that.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Handle Windows nul device in unlink-if-ordinary.c
2023-03-13 5:15 ` Himal
@ 2023-04-29 18:10 ` Jeff Law
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Law @ 2023-04-29 18:10 UTC (permalink / raw)
To: Himal, gcc-patches
On 3/12/23 23:15, Himal wrote:
> On 3/12/2023 1:48 AM, Jeff Law wrote:
>>
>>
>> On 1/6/23 01:31, anothername27-unity--- via Gcc-patches wrote:
>>> From: Himal <himalr@proton.me>
>>>
>>> Hi,
>>>
>>> This might be a better fix.
>>>
>>> Regards.
>>>
>>> PS. I had to use a different email.
>>>
>>> ---
>>> libiberty/unlink-if-ordinary.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/libiberty/unlink-if-ordinary.c
>>> b/libiberty/unlink-if-ordinary.c
>>> index 84328b216..e765ac8b1 100644
>>> --- a/libiberty/unlink-if-ordinary.c
>>> +++ b/libiberty/unlink-if-ordinary.c
>>> @@ -62,6 +62,12 @@ was made to unlink the file because it is special.
>>> int
>>> unlink_if_ordinary (const char *name)
>>> {
>>> +/* MS-Windows 'stat' function (and in turn, S_ISREG)
>>> + reports the null device as a regular file. */
>>> +#ifdef _WIN32
>>> + if (stricmp (name, "nul") == 0)
>>> + return 1;
>>> +#endif
>
> Hi Jeff, Thanks for the response.
>
>> Umm, wouldn't this return true for a real file called nul in the
>> current directory? ie, don't you need to distinguish between the nul
>> device and a file named nul based on the full path?
>
> I don't think that we can create a file called nul under Windows.
>
>> And not being a windows person, I'd really like to see some
>> documentation which indicates that stat on the null device will
>> indicate its a regular file. Alternately if one of the windows
>> experts here can chime in, it'd be appreciated.
>> jeff
>
> I found these patches that might indicate the same thing.
>
> https://src.fedoraproject.org/rpms/binutils/blob/0b119dd9d51a3763db7d6fea1b51a03494cb96d8/f/binutils-CVE-2021-20197.patch#_121-135
>
> https://github.com/msys2/MINGW-packages/pull/10541/files
>
> I would like to see some input from a Windows developer as well.
>
> BTW, This doesn't affecting anything. I stumbled upon this while
> debugging another
> [bug](https://sourceware.org/bugzilla/show_bug.cgi?id=29947). I noticed
> it's calling unlink function for the nul device as well, but it wasn't
> throwing any errors or anything like that.
I'm inclined to go ahead and commit this. I think the only other
question I have is the use of stricmp. That's not strictly ISO,
strcasecmp would be preferred. But I don't know enough about the
windows environment to know if they picked up strcasecmp over time.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-29 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 3:09 [PATCH] libiberty: Handle Windows nul device in unlink-if-ordinary.c [PR108276] Himal
2023-01-06 8:23 ` [PATCH] Handle Windows nul device in unlink-if-ordinary.c anothername27-unity
2023-01-06 8:31 ` anothername27-unity
2023-03-11 20:18 ` Jeff Law
2023-03-13 5:15 ` Himal
2023-04-29 18:10 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).