* [committed] C-SKY: Define SYSROOT_SUFFIX_SPEC.
@ 2023-01-13 12:43 Xianmiao Qu
2023-01-20 17:27 ` Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Xianmiao Qu @ 2023-01-13 12:43 UTC (permalink / raw)
To: gcc-patches
The earlier patch
https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575418.html
refine the way to generate sysroot suffix, but it can't find the
right path for all CPUs. The SYSROOT_SUFFIX_SPEC should be defined
to fix it.
gcc/
* config/csky/csky-linux-elf.h (SYSROOT_SUFFIX_SPEC): New.
---
gcc/config/csky/csky-linux-elf.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gcc/config/csky/csky-linux-elf.h b/gcc/config/csky/csky-linux-elf.h
index 677c201b218..3f67af64c15 100644
--- a/gcc/config/csky/csky-linux-elf.h
+++ b/gcc/config/csky/csky-linux-elf.h
@@ -65,6 +65,14 @@
#define GLIBC_DYNAMIC_LINKER "/lib/ld-linux-cskyv2%{mfloat-abi=hard:-hf}%{mbig-endian:-be}.so.1"
+#define SYSROOT_SUFFIX_SPEC \
+ "%{mbig-endian:/big}" \
+ "%{mcpu=ck807*:/ck807}" \
+ "%{mcpu=ck860*:/ck860}" \
+ "%{mcpu=ck800*:/ck800}" \
+ "%{mfloat-abi=softfp:/soft-fp}" \
+ "%{mfloat-abi=hard:/hard-fp}"
+
#define LINUX_TARGET_LINK_SPEC "%{h*} %{version:-v} \
%{b} \
%{static:-Bstatic} \
--
2.32.1 (Apple Git-133)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [committed] C-SKY: Define SYSROOT_SUFFIX_SPEC.
2023-01-13 12:43 [committed] C-SKY: Define SYSROOT_SUFFIX_SPEC Xianmiao Qu
@ 2023-01-20 17:27 ` Joseph Myers
2023-01-25 9:41 ` Cooper Qu
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2023-01-20 17:27 UTC (permalink / raw)
To: Xianmiao Qu; +Cc: gcc-patches
On Fri, 13 Jan 2023, Xianmiao Qu via Gcc-patches wrote:
> The earlier patch
> https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575418.html
> refine the way to generate sysroot suffix, but it can't find the
> right path for all CPUs. The SYSROOT_SUFFIX_SPEC should be defined
> to fix it.
I think this caused the build failures with build-many-glibcs.py shown by
my bot. SYSROOT_SUFFIX_SPEC should not be defined for a
--disable-multilib build; in such a build you can expect a single sysroot
without a suffix involved. Thus, you should put the SYSROOT_SUFFIX_SPEC
definition in a separate header only used if test "x${enable_multilib}" =
xyes (as in the config.gcc code removed in the older patch you refer to
above), or something similar.
https://sourceware.org/pipermail/libc-testresults/2023q1/010706.html
The error is:
/scratch/jmyers/glibc-bot/install/compilers/csky-linux-gnuabiv2/csky-glibc-linux-gnuabiv2/bin/ld: cannot find -lc: No such file or directory
(linking shared libgcc).
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [committed] C-SKY: Define SYSROOT_SUFFIX_SPEC.
2023-01-20 17:27 ` Joseph Myers
@ 2023-01-25 9:41 ` Cooper Qu
0 siblings, 0 replies; 3+ messages in thread
From: Cooper Qu @ 2023-01-25 9:41 UTC (permalink / raw)
To: Joseph Myers; +Cc: gcc-patches
On Fri, Jan 20, 2023 at 05:27:26PM +0000, Joseph Myers wrote:
> I think this caused the build failures with build-many-glibcs.py shown by
> my bot. SYSROOT_SUFFIX_SPEC should not be defined for a
> --disable-multilib build; in such a build you can expect a single sysroot
> without a suffix involved. Thus, you should put the SYSROOT_SUFFIX_SPEC
> definition in a separate header only used if test "x${enable_multilib}" =
> xyes (as in the config.gcc code removed in the older patch you refer to
> above), or something similar.
>
Hi Joseph,
Sorry, this is indeed caused by this patch. I tested the multilib scenario, but I didn't test the non-multilib, so I didn't find this problem in time.
Now I have fixed this problem, the patch can be seen in
https://gcc.gnu.org/pipermail/gcc-patches/2023-January/610534.html
Hope it also works for you, If you still have problems, please contact me.
Thanks,
Cooper
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-25 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-13 12:43 [committed] C-SKY: Define SYSROOT_SUFFIX_SPEC Xianmiao Qu
2023-01-20 17:27 ` Joseph Myers
2023-01-25 9:41 ` Cooper Qu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).