* [PATCH] RISC-V: Fix bug of before_p function
@ 2023-01-18 3:09 juzhe.zhong
2023-01-27 10:09 ` Kito Cheng
0 siblings, 1 reply; 2+ messages in thread
From: juzhe.zhong @ 2023-01-18 3:09 UTC (permalink / raw)
To: gcc-patches; +Cc: kito.cheng, palmer, Ju-Zhe Zhong
From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
gcc/ChangeLog:
* config/riscv/riscv-vsetvl.cc (before_p): Fix bug.
---
gcc/config/riscv/riscv-vsetvl.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv-vsetvl.cc b/gcc/config/riscv/riscv-vsetvl.cc
index 26d096ea939..728a32dacd6 100644
--- a/gcc/config/riscv/riscv-vsetvl.cc
+++ b/gcc/config/riscv/riscv-vsetvl.cc
@@ -188,7 +188,7 @@ real_insn_and_same_bb_p (const insn_info *insn, const bb_info *bb)
static bool
before_p (const insn_info *insn1, const insn_info *insn2)
{
- return insn1->compare_with (insn2) == -1;
+ return insn1->compare_with (insn2) < 0;
}
static bool
--
2.36.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] RISC-V: Fix bug of before_p function
2023-01-18 3:09 [PATCH] RISC-V: Fix bug of before_p function juzhe.zhong
@ 2023-01-27 10:09 ` Kito Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Kito Cheng @ 2023-01-27 10:09 UTC (permalink / raw)
To: juzhe.zhong; +Cc: gcc-patches, palmer
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
Committed with more comments to describe why this should be fixed.
On Wed, Jan 18, 2023 at 11:10 AM <juzhe.zhong@rivai.ai> wrote:
> From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vsetvl.cc (before_p): Fix bug.
>
> ---
> gcc/config/riscv/riscv-vsetvl.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/riscv/riscv-vsetvl.cc
> b/gcc/config/riscv/riscv-vsetvl.cc
> index 26d096ea939..728a32dacd6 100644
> --- a/gcc/config/riscv/riscv-vsetvl.cc
> +++ b/gcc/config/riscv/riscv-vsetvl.cc
> @@ -188,7 +188,7 @@ real_insn_and_same_bb_p (const insn_info *insn, const
> bb_info *bb)
> static bool
> before_p (const insn_info *insn1, const insn_info *insn2)
> {
> - return insn1->compare_with (insn2) == -1;
> + return insn1->compare_with (insn2) < 0;
> }
>
> static bool
> --
> 2.36.3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-27 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-18 3:09 [PATCH] RISC-V: Fix bug of before_p function juzhe.zhong
2023-01-27 10:09 ` Kito Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).