From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>
Subject: [PATCH] Fix possible sanopt compile-time hog
Date: Tue, 14 Feb 2023 16:20:24 +0100 (CET) [thread overview]
Message-ID: <20230214152025.2226E138E3@imap2.suse-dmz.suse.de> (raw)
While working on bitmap operations I figured sanopt.cc uses
a sbitmap worklist, iterating using bitmap_first_set_bit on it.
That's quadratic since bitmap_first_set_bit for sbitmap is O(n).
The fix is to use regular bitmaps for the worklist and the bitmap
feeding it and to avoid a useless copy.
Bootstrap and regtest running on x86_64-unknown-linux-gnu.
OK for trunk?
Thanks,
Richard.
* sanopt.cc (sanitize_asan_mark_unpoison): Use bitmap
for with_poison and alias worklist to it.
(sanitize_asan_mark_poison): Likewise.
---
gcc/sanopt.cc | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/gcc/sanopt.cc b/gcc/sanopt.cc
index aed22850079..b356a21eca3 100644
--- a/gcc/sanopt.cc
+++ b/gcc/sanopt.cc
@@ -987,15 +987,11 @@ static void
sanitize_asan_mark_unpoison (void)
{
/* 1) Find all BBs that contain an ASAN_MARK poison call. */
- auto_sbitmap with_poison (last_basic_block_for_fn (cfun) + 1);
- bitmap_clear (with_poison);
+ auto_bitmap with_poison;
basic_block bb;
FOR_EACH_BB_FN (bb, cfun)
{
- if (bitmap_bit_p (with_poison, bb->index))
- continue;
-
gimple_stmt_iterator gsi;
for (gsi = gsi_last_bb (bb); !gsi_end_p (gsi); gsi_prev (&gsi))
{
@@ -1010,8 +1006,8 @@ sanitize_asan_mark_unpoison (void)
auto_sbitmap poisoned (last_basic_block_for_fn (cfun) + 1);
bitmap_clear (poisoned);
- auto_sbitmap worklist (last_basic_block_for_fn (cfun) + 1);
- bitmap_copy (worklist, with_poison);
+ /* We now treat with_poison as worklist. */
+ bitmap worklist = with_poison;
/* 2) Propagate the information to all reachable blocks. */
while (!bitmap_empty_p (worklist))
@@ -1088,8 +1084,7 @@ static void
sanitize_asan_mark_poison (void)
{
/* 1) Find all BBs that possibly contain an ASAN_CHECK. */
- auto_sbitmap with_check (last_basic_block_for_fn (cfun) + 1);
- bitmap_clear (with_check);
+ auto_bitmap with_check;
basic_block bb;
FOR_EACH_BB_FN (bb, cfun)
@@ -1108,8 +1103,8 @@ sanitize_asan_mark_poison (void)
auto_sbitmap can_reach_check (last_basic_block_for_fn (cfun) + 1);
bitmap_clear (can_reach_check);
- auto_sbitmap worklist (last_basic_block_for_fn (cfun) + 1);
- bitmap_copy (worklist, with_check);
+ /* We now treat with_check as worklist. */
+ bitmap worklist = with_check;
/* 2) Propagate the information to all definitions blocks. */
while (!bitmap_empty_p (worklist))
--
2.35.3
next reply other threads:[~2023-02-14 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 15:20 Richard Biener [this message]
2023-02-14 15:55 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214152025.2226E138E3@imap2.suse-dmz.suse.de \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).