From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix possible sanopt compile-time hog
Date: Tue, 14 Feb 2023 16:55:47 +0100 [thread overview]
Message-ID: <Y+uvA012RYBIvn8S@tucnak> (raw)
In-Reply-To: <20230214152025.2226E138E3@imap2.suse-dmz.suse.de>
On Tue, Feb 14, 2023 at 04:20:24PM +0100, Richard Biener wrote:
> While working on bitmap operations I figured sanopt.cc uses
> a sbitmap worklist, iterating using bitmap_first_set_bit on it.
> That's quadratic since bitmap_first_set_bit for sbitmap is O(n).
>
> The fix is to use regular bitmaps for the worklist and the bitmap
> feeding it and to avoid a useless copy.
>
> Bootstrap and regtest running on x86_64-unknown-linux-gnu.
>
> OK for trunk?
>
> Thanks,
> Richard.
>
> * sanopt.cc (sanitize_asan_mark_unpoison): Use bitmap
> for with_poison and alias worklist to it.
> (sanitize_asan_mark_poison): Likewise.
Ok, thanks.
Jakub
prev parent reply other threads:[~2023-02-14 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 15:20 Richard Biener
2023-02-14 15:55 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+uvA012RYBIvn8S@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).