From: Richard Biener <rguenther@suse.de>
To: gcc-patches@gcc.gnu.org
Cc: Jakub Jelinek <jakub@redhat.com>, aldyh@redhat.com, amacleod@redhat.com
Subject: [PATCH] tree-optimization/109170 - bogus use-after-free with __builtin_expect
Date: Fri, 17 Mar 2023 13:18:32 +0100 (CET) [thread overview]
Message-ID: <20230317121833.16A961346F@imap2.suse-dmz.suse.de> (raw)
The following adds a missing range-op for __builtin_expect which
helps -Wuse-after-free to detect the case a realloc original
pointer is used when the result was NULL.
Bootstrap and regtest running on x86_64-unknown-linux-gnu, OK?
PR tree-optimization/109170
* gimple-range-op.cc (cfn_expect): New.
(gimple_range_op_handler::maybe_builtin_call): Handle
__builtin_expect.
* gcc.dg/Wuse-after-free-pr109170.c: New testcase.
---
gcc/gimple-range-op.cc | 25 +++++++++++++++++++
.../gcc.dg/Wuse-after-free-pr109170.c | 15 +++++++++++
2 files changed, 40 insertions(+)
create mode 100644 gcc/testsuite/gcc.dg/Wuse-after-free-pr109170.c
diff --git a/gcc/gimple-range-op.cc b/gcc/gimple-range-op.cc
index a5d625387e7..f3d6e29e58d 100644
--- a/gcc/gimple-range-op.cc
+++ b/gcc/gimple-range-op.cc
@@ -309,6 +309,25 @@ public:
}
} op_cfn_constant_p;
+// Implement range operator for integral CFN_BUILT_IN_EXPECT.
+class cfn_expect : public range_operator
+{
+public:
+ using range_operator::fold_range;
+ virtual bool fold_range (irange &r, tree, const irange &lh,
+ const irange &, relation_trio) const
+ {
+ r = lh;
+ return true;
+ }
+ virtual bool op1_range (irange &r, tree, const irange &lhs,
+ const irange &, relation_trio) const
+ {
+ r = lhs;
+ return true;
+ }
+} op_cfn_expect;
+
// Implement range operator for CFN_BUILT_IN_SIGNBIT.
class cfn_signbit : public range_operator_float
{
@@ -966,6 +985,12 @@ gimple_range_op_handler::maybe_builtin_call ()
m_int = &op_cfn_parity;
break;
+ case CFN_BUILT_IN_EXPECT:
+ m_valid = true;
+ m_op1 = gimple_call_arg (call, 0);
+ m_int = &op_cfn_expect;
+ break;
+
default:
break;
}
diff --git a/gcc/testsuite/gcc.dg/Wuse-after-free-pr109170.c b/gcc/testsuite/gcc.dg/Wuse-after-free-pr109170.c
new file mode 100644
index 00000000000..fa7dc66d66c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wuse-after-free-pr109170.c
@@ -0,0 +1,15 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -Wuse-after-free" } */
+
+unsigned long bufmax = 0;
+unsigned long __open_catalog_bufmax;
+void *realloc(void *, __SIZE_TYPE__);
+void free(void *);
+
+void __open_catalog(char *buf)
+{
+ char *old_buf = buf;
+ buf = realloc (buf, bufmax);
+ if (__builtin_expect ((buf == ((void *)0)), 0))
+ free (old_buf); /* { dg-bogus "used after" } */
+}
--
2.35.3
next reply other threads:[~2023-03-17 12:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 12:18 Richard Biener [this message]
2023-03-17 12:43 ` Jakub Jelinek
2023-03-17 12:53 ` Richard Biener
2023-03-17 12:59 ` Jakub Jelinek
2023-03-17 13:55 ` Richard Biener
2023-03-17 14:03 ` Jakub Jelinek
2023-03-17 14:18 ` Richard Biener
2023-03-17 14:52 ` Jakub Jelinek
2023-03-20 8:21 ` Richard Biener
2023-03-20 12:12 ` Richard Biener
2023-03-20 13:22 ` Jakub Jelinek
2023-03-21 8:21 ` Richard Biener
2023-03-21 8:23 ` Jakub Jelinek
2023-03-17 13:59 ` Andrew MacLeod
2023-04-27 12:10 Richard Biener
[not found] <34641.123042708104200740@us-mta-611.us.mimecast.lan>
2023-04-27 12:11 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317121833.16A961346F@imap2.suse-dmz.suse.de \
--to=rguenther@suse.de \
--cc=aldyh@redhat.com \
--cc=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).