From: Jakub Jelinek <jakub@redhat.com>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org, Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATCH] tree-optimization/109170 - bogus use-after-free with __builtin_expect
Date: Mon, 20 Mar 2023 14:22:06 +0100 [thread overview]
Message-ID: <ZBhd/rwNkNxMjSCR@tucnak> (raw)
In-Reply-To: <nycvar.YFH.7.77.849.2303201211160.18795@jbgna.fhfr.qr>
On Mon, Mar 20, 2023 at 12:12:14PM +0000, Richard Biener wrote:
> PR tree-optimization/109170
> * gimple-range-op.cc (cfn_pass_through_arg1): New.
> (gimple_range_op_handler::maybe_builtin_call): Handle
> __builtin_expect and similar via cfn_pass_through_arg1
> and inspecting the calls fnspec.
> * builtins.cc (builtin_fnspec): Handle BUILT_IN_EXPECT
> and BUILT_IN_EXPECT_WITH_PROBABILITY.
I'm still worried about this builtins.cc change, can't we defer
that part till GCC 14 where there will be enough time to see if it
doesn't result in some undesirable problems (__builtin_expect* being
optimized away when it still shouldn't etc.)?
>
> * gcc.dg/Wuse-after-free-pr109170.c: New testcase.
> * gcc.dg/tree-ssa/ssa-lim-21.c: Adjust.
> * gcc.dg/predict-20.c: Likewise.
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2023-03-20 13:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 12:18 Richard Biener
2023-03-17 12:43 ` Jakub Jelinek
2023-03-17 12:53 ` Richard Biener
2023-03-17 12:59 ` Jakub Jelinek
2023-03-17 13:55 ` Richard Biener
2023-03-17 14:03 ` Jakub Jelinek
2023-03-17 14:18 ` Richard Biener
2023-03-17 14:52 ` Jakub Jelinek
2023-03-20 8:21 ` Richard Biener
2023-03-20 12:12 ` Richard Biener
2023-03-20 13:22 ` Jakub Jelinek [this message]
2023-03-21 8:21 ` Richard Biener
2023-03-21 8:23 ` Jakub Jelinek
2023-03-17 13:59 ` Andrew MacLeod
2023-04-27 12:10 Richard Biener
[not found] <34641.123042708104200740@us-mta-611.us.mimecast.lan>
2023-04-27 12:11 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhd/rwNkNxMjSCR@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).